Update @stacks/[email protected], fix bns lookupProfile

[kyranjamie]

Try out this version of the Hiro Wallet - download extension builds.

Pushing @pradel's #2087 PR again so our CI/test builds run.

This PR will fixs the bns lookupProfile functionality. @pradel will write up steps we need to follow to QA this. cc/ @andresgalante can you plan when we'll include this in release?

[friedger]

There is a bug in 3.1.0 hirosystems/stacks.js#1152

[kyranjamie]

Thanks @friedger, yes this one is def not to merge yet. Converted to draft.

[pradel]

@kyranjamie would it be possible to get a new build with 3.1.1 please 🙏 ?

[kyranjamie]

@pradel done, building now

[pradel]

Amazing thanks!

[pradel]

Hey there, any update to merge this one? :)

[pradel]

The changes introduced in this pr are mostly related to how the profile is signed, so I think you need to login to an app using the publish_data scope. You could probably use the TODO app on this branch hirosystems/todos#104.

You would have to log in using an account owning a .btc name and you can try to call the lookupProfile function that would fail with the current Hiro wallet version and work with the one built on this branch.

[andresgalante]

@kyranjamie I'd like to include this on our next release if possible.

I'll move it to "QA" so @Eshwari007 or @timstackblock can pick it up while it's being reviewed.

[Eshwari007]

@kyranjamie any input on how to test the ticket is much appreciated.Thx in ad

[andresgalante]

@Eshwari007 this is how to test it #2089 (comment)

[Eshwari007]

@kyranjamie Want to run by you if am missing something here.

• I created a todos' using a test btc name under : https://todos-lovat.vercel.app/todos/
• I tried looking up for my btc name todos https://todos-lovat.vercel.app/todos/hiromaintest.btc
• Receiving the below:

Used the link from hirosystems/todos#103

[andresgalante]

Hi @pradel, would you be able to help Esh test this PR? if async on the ticket is too slow, we can try on Discord

[pradel]

@andresgalante happy to help, do you have a channel on discord for this?

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/blockstack/stacks-wallet-web/9SPM26G5Whw7Nt2tzV8NKPVWL453
✅ Preview: https://stacks-wallet-web-git-feature-stacks-3-1-0-blockstack.vercel.app

[pradel]

I uploaded a build from the Todo app pending pr to netlify for you to test more easily https://blissful-agnesi-f97d5f.netlify.app/.

Now we just need #2194 to be merged into this branch and get a new build for the wallet in order to finish the testing part :)

Edit: The netlify build is not working so I prepared you a Sigle branch in order to test https://sigle-1ljk1nxmn-sigle.vercel.app/login

[Eshwari007]

I uploaded a build from the Todo app pending pr to netlify for you to test more easily https://blissful-agnesi-f97d5f.netlify.app/.

Now we just need #2194 to be merged into this branch and get a new build for the wallet in order to finish the testing part :)
get a new build for the wallet in order to finish the testing part

cc @andresgalante @kyranjamie

[pradel]

Testing flow

Demo link: https://sigle-9i6eqj7dj-sigle.vercel.app/login

These are the tests cases with the new Hiro wallet version:

1. legacy account migration: use an old account 12 word key with a *.id.blockstack attached to it and login. You should be able to see your existing drafts, published posts, visiting my blog as a public visitor should work too.
2. legacy account migration: use an old account 12 word key with a *.id.stx attached to it and login. You should be able to see your existing drafts, published posts, visiting my blog as a public visitor should work too.
3. account with *.btc domain: login with an account owning a .btc domain. You should see the .btc username in the left side menu (back part). Create a draft, publish it and then visit your public blog should work.
4. registering new account: create a new account without username linked to it and register a new username. You should see the .id.stx username in the left side menu (back part). Create a draft, publish it and then visit your public blog should work.

To view your public blog, on the top right corner of the dashboard click on this button 👇

[Eshwari007]

https://sigle-9i6eqj7dj-sigle.vercel.app/login

@leopradel Somewhat good news.

Use case 3 : I was able to login in with .btc address ( bns address visible on the left-hand corner as well), create a blog ,save and publish it. I tried selecting 'view my blog but received 'token issuer error 'https://sigle-9i6eqj7dj-sigle.vercel.app/hiromaintest.btc. However, in the sigle app itself, I was able to view my test blog under the Published and Draft section.

User case 4: I tried login with a new account without username and received the following error on console

Note: I dont have an account with bns name as per use case 1 and 2 hence will create one and test the app as well

[pradel]

Thanks for trying it out!

For case 3: the fact that you are seeing the "token issuer error" means that the profile is not signed properly, also meaning that the test failed.
Calling the API https://stacks-node-api.mainnet.stacks.co/v1/names/hiromaintest.btc show that your username is linked to the address SP17YZQB1228EK9MPHQXA8GC4G3HVWZ66X7VRPMAX. However your profile public key is 0217ecac7614a7a724f0addfc4241f756129171cc460eef430e895f04a08ff5658, and getting the address is actually not matching the one owned by the name.

const { getAddressFromPublicKey } = require('@stacks/transactions');
console.log(getAddressFromPublicKey('0217ecac7614a7a724f0addfc4241f756129171cc460eef430e895f04a08ff5658'));
// => SP2FB4MP6QZ1JV8JJZTCBYP7P9T6GXB0842YHYVX3

This is the result you would get by logging in with the current Hiro wallet version (without the fix from this pull request) as the profile is signed using the old stacks key. Can I ask you to triple check that the extension you tried does have the changes made in this pull request? #2196

For case 4: it's fine as it's not related to this pull request and the Hiro wallet in general but rather the subdomain registrar (I created an issue in the repo already).

[Eshwari007]

@pradel Spoke too soon.
I logged out and retested the entire scenario (this time with both .stx and .btc)with #2196

Findings:

Use case 3: the irony is that this partially worked bfr the token error was produced but now with the fix branch am not able to see any actions on the app upon selecting the account with btc on it

sigle.btc.account.mov

Use case 4:I was able to sign in with an account that doesn't have a bns attached to it and it created name.stx for me in the app

[kyranjamie]

When QA approved, I'll make these changes #2172 (rather than merging this PR), as it'll be a real pain to rebase on.

[pradel]

@Eshwari007 I did the testing on multiple devices and it worked all the time. Would you mind trying one more time with a clean cache? 🙏

[Eshwari007]

@Eshwari007 I did the testing on multiple devices and it worked all the time. Would you mind trying one more time with a clean cache? 🙏

@pradel Yay-good news. Test passed -used #2172
All the use cases passed. cc @kyranjamie

[andresgalante]

Thanks a lot @Eshwari007 for testing this PR. Lets get it into the next release after 3.1