feat(sbtc): enroll contract call #212
Merged
+154
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
force-pushed
the
feat/enroll-contract-call
branch
from
5388506 to
f3e151c
Compare
Deploying lockstacks with
|
| Latest commit: |
6a67006
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a5918aaa.lockstacks.pages.dev |
| Branch Preview URL: | https://feat-enroll-contract-call.lockstacks.pages.dev |
kyranjamie
force-pushed
the
feat/enroll-contract-call
branch
3 times, most recently
from
7c4deaa to
2fb207c
Compare
|
UI when the user is enrolled already: 
|
camerow
reviewed
Dec 17, 2024
src/hooks/use-enroll-transaction.ts
Outdated
| return useMemo( | ||
| () => ({ | ||
| get enrollmentStatus() { | ||
| // TODO: investigate how to find enrollment state, read contract? |
There was a problem hiding this comment.
Isn't that useEnrolledStatus ?
camerow
reviewed
Dec 17, 2024
| step={2} | ||
| disabled={!isSignedIn} | ||
| disabled={!isSignedIn || enrolledQuery?.isEnrolled} |
There was a problem hiding this comment.
If they are enrolled should we link out to bitcoinismore so they can see status etc?
|
@kyranjamie is this close to release for today? |
kyranjamie
force-pushed
the
feat/enroll-contract-call
branch
from
2fb207c to
473ce3b
Compare
I need to investigate the address bug screetshot in pr body |
|
I can run and debug |
camerow
approved these changes
Dec 18, 2024
camerow
force-pushed
the
feat/enroll-contract-call
branch
2 times, most recently
from
99bd2b9 to
cb8bd8c
Compare
fbwoolf
approved these changes
Dec 18, 2024
camerow
force-pushed
the
feat/enroll-contract-call
branch
from
cb8bd8c to
6a67006
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running into same issue as we've seen with Ledger, though the tx does actually broadcast
Edit; this is fixed, though I still see NaN values on the final review screen. A slight improvement at least, PR coming extension side.