Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sortindex of remaining workflows when disabling a workflow #201

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

olivabigyo
Copy link
Contributor

Disabling a workflow just removes it from the sort order without updating the sortindex of the remaining active workflow. This leaves a gap in the sortindex, which can cause different problems: eg., you can't "move up" the workflow which was immediately below the disabled one, or "move down" the one which was above it. Or, if you now activate a new workflow, it will get the same sortindex as the previously last one…

This is the root cause of the problems reported in issue #128.

This PR adds a function to workflow_manager.php to rearrange the sortindex of the remaining workflows when disabling a workflow.

@NinaHerrmann
Copy link
Contributor

Seems like there were only some problems with the nodejs container and rerunning fixed it. Thank you again so much for providing a solution that fast!

@NinaHerrmann NinaHerrmann merged commit f1ef4a6 into learnweb:master Mar 14, 2024
23 checks passed
NinaHerrmann added a commit that referenced this pull request Jun 19, 2024
* Removed ,

* CI: Update for Moodle 4.2

* Workflow backup: Do not save attributes when they are null

* Bump version

* MBS-7377: Fix workflowoverview for big instances

* Fix wrong calculation of courses counts in template context

* fix upload workflow (#185)

* fix upload workflow

* inserting feedback

* finally

* Add check if process exists. (#191)

This prevents courses to be processed which had been rescued by the teacher.

* Update README.md

Make Subplugin List (and link to wiki) more apparent

* Improve help text for integration of icons (manual trigger) (#193)

* Improved help text for the integration of icons

* Improved help text for the integration of icons

* Update for Moodle 4.3 (#190)

* CI: Update for Moodle 4.3

* Prevent dynamic property access on classes for PHP 8.2

* phpcbf for styles etc.

---------

Co-authored-by: Justus Dieckmann <[email protected]>
Co-authored-by: NinaHerrmann <[email protected]>

* Hide menu when there is no manual workflow (#195)

Co-authored-by: Justus Dieckmann <[email protected]>

* Fix step and trigger reordering: only change the relevant workflow (#200)

* Reorder the remaining active workflows when disabling a workflow (#201)

This fixes #128.

* Show menu entry when a manual or automatic workflow is active (#199)

* Show menu point when a manual or automatic workflow is active

* Rename reset cache function

* Show menu entry if there are workflows other than the default two

---------

Co-authored-by: Justus Dieckmann <[email protected]>

* Check backup consistency before importing workflow (#196)

* Check backup consistency before importing workflow

* Fix PHPDocs

* Use existing category in backup_and_restore test

* lifecycletrigger_categories: A bit of general refactoring

* lifecycletrigger_categories: Don't fail if category doesn't exist

* Add possibility to force import of errorneous backup

* Use $force = false as default in restore_workflow:execute

* Display only unique errors when Workflows causes multiple errors

---------

Co-authored-by: Justus Dieckmann <[email protected]>
Co-authored-by: NinaHerrmann <[email protected]>

* CI: Update for Moodle 4.4

* Codestyle PHPCBF

* Sort strings in lang files alphabetically

* Fix sortindex gaps in upgrade step

* Bump version

* The columns in active_manual_workflows_table shouldn't be sortable

* Shell escape the release notes in the release workflow (#207)

Co-authored-by: Justus Dieckmann <[email protected]>

* Fix mustache

* added mtrace statement for logging failed mails (#214)

* Shell escape release workflow for realsies this time (#208)

---------

Co-authored-by: Justus Dieckmann <[email protected]>
Co-authored-by: Philipp Memmel <[email protected]>
Co-authored-by: Justus Dieckmann <[email protected]>
Co-authored-by: Melanie Treitinger <[email protected]>
Co-authored-by: KerstinSc <[email protected]>
Co-authored-by: Kata <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants