Skip to content

Commit

Permalink
inserting feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
NinaHerrmann committed Jul 6, 2023
1 parent 4c7fdf5 commit d411d69
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 12 deletions.
2 changes: 1 addition & 1 deletion classes/local/backup/restore_lifecycle_workflow.php
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ private function load_workflow() {
$this->workflow->timeactive = null;
$this->workflow->timedeactive = null;
$this->workflow->sortindex = null;
$this->workflow->id = workflow_manager::insert_or_update($this->workflow);
workflow_manager::insert_or_update($this->workflow);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/behat/manual_trigger.feature
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@tool @tool_lifecycle @manuel_trigger
@tool @tool_lifecycle @manual_trigger
Feature: Add a manual trigger and test view and actions as a teacher

Background:
Expand Down
17 changes: 7 additions & 10 deletions tests/fixtures/simpleworkflow.xml
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
<?xml version="1.0"?>
<workflow id="143" title="Ein Workflow basierend auf Rollen" timeactive="1688629134" timedeactive="" sortindex="6" manual="" displaytitle="Find courses without students" rollbackdelay="7776000" finishdelay="7776000" delayforallworkflows="0">
<step id="100" instancename="Test all courses" workflowid="143" subpluginname="adminapprove" sortindex="1">
<setting name="statusmessage" value="Manually check"/>
</step>
<trigger id="67" instancename="Filter without students" workflowid="143" subpluginname="byrole" sortindex="1">
<setting name="roles" value="5"/>
<setting name="delay" value="120"/>
</trigger>
</workflow>
<workflow id="7" title="Ein Workflow basierend auf Rollen" manual="" displaytitle="Find courses without students" rollbackdelay="7776000" finishdelay="7776000" delayforallworkflows="0">
<step id="7" instancename="Duplicate course" workflowid="7" subpluginname="duplicate" sortindex="1"/>
<trigger id="7" instancename="Filter without students" workflowid="7" subpluginname="byrole" sortindex="1">
<setting name="roles" value="5"/>
<setting name="delay" value="120"/>
</trigger>
</workflow>

0 comments on commit d411d69

Please sign in to comment.