-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified Chinese Translation, working with TexLive.net #221
Conversation
There is no need to open a new PR simply push to your fork and this PR will automatically update, then it is easier to see what changes have been made. Also don't worry too much about the CNAME file, if you take |
Cheers! I've made the changes and accidentally found that the commit history after submitting this PR has been attached to this discussion. That's awesome! Thanks for your suggestion, the DNS name has been deleted from my CNAME.txt now - I am not going to hijack it by any means :-) |
Why do many of the examples use the |
I think UTF8 is the default now (and the only supported encoding for luatex or xetex), so this could be dropped, (via google translate) the ctex manual says: 4.2 Chinese encoding GBK UTF8 |
It's a personal practice of 'explicit is better than implicit' from the Zen of Python. But I am happy to remove it as the examples work fine without it as you suggested. |
Thank you for quoting the documents. All examples work fine without the explicit UTF8 definition indeed. |
To better review translations, is it possible to first have a clean copy of English version under Reviewing selected commits does the trick, but the English version would still be missing in contexts of review comments. Some general questions:
|
@muzimuzhi I'm not sure I did quite what you intended I locally cherry picked affb6e8 into main (which added the English text under zh as expected) then pushed here and that shows in the three dot diff as in main...libralibra:learnlatex.github.io:mainch But the PR still shows the difs against which it is forked |
@davidcarlisle Thank you! According to how three-dot Git diff works unfortunately this is expected behavior.
Now it shows "This branch has conflicts that must be resolved". Not sure if it's easy to add a new commit which reverts affb6e8 to the head branch. I will try it locally. |
@muzimuzhi @libralibra there is some discussion with @stone-zeng in #77 and I think the suggestion there was to use zh-hans (part of the discussion relates to earlier versions of the site when the language switching may not have been quite the same) |
I have checked that the language switching does work using the longer codes such as https://davidcarlisle.github.io/learnlatex.github.io/zh-hans/ so if you git rename the directory to zh and adjust the |
add placeholder for Traditional Chinese (zh-hant) add extra space before and after English words in Chinese translation
Thanks for your reply. Yes, the longer language code did work. I have made changes slowly to reflect what has been discussed above, as shown in the test site: https://libralibra.github.io/learnlatex.github.io/zh-hans/
|
@libralibra thanks for this
Thanks for this. If you let me know when you think it is done, I will merge. If other changes come up after the merge you can always make a new PR to add corrections of course. @muzimuzhi @stone-zeng similarly comments before or after the merge are always welcome.
Thank you. It is simpler to limit a PR to one script, so if you could make a new PR for any zh-hant additions rather than adding both here that would be helpful . Thank you.
thanks
Yes there should be no english under the zh-hans directory. What @muzimuzhi meant by the above comment about having english (which you could do for any new zh-hant translation). Is to start by populating |
@libralibra also don't worry too much about the conflict under |
Thank you for your reply. The current state of the Simplified translation can be considered as finished. |
Yes, please merge after correcting the conflicts. Thank you! |
@libralibra thanks a lot https://www.learnlatex.org/zh-hans/ I hope you can read that better than I can:-) |
@libralibra I added a |
@libralibra should there be a translation for the "meta" heading in the page footer? It seems most of the the languages failed to translate this (or translated it unchanged to Meta) but it looks a bit odd in latin script here (because I can read it:-) It would need to be in Also I notice that while generally we force |
@davidcarlisle I struggled a little bit between using the translation and keeping the original word during the translation process. You could do either I think. For a person who would like to learn LaTeX, it shouldn't be a problem. Regarding the font, it should be fine to let the local system selects whatever it likes as it won't affect the user experience too much. |
@libralibra thanks I think I'll update the text, "Meta" is not really that good a heading in English (and is probably difficult to translate to many languages) I don't think we need to change the English but I don't think it's important to preserve the meaning and highlight that heading by being the only Latin script heading. pushed 3f12736 I'll leave the font as it is. |
Add Simplified Chinese Translation by following translation instructions
2. Add a temporary patch to make all examples work with TexLive.net (click the TexLive.net button to get the examples that contains Chinese punctuations compiled successfully)Rewrite
language-01.md
to reflect Chinese language-specific issuesCheck all examples in the forked git-page site before bringing back
CNAME.txt
(https://libralibra.github.io/learnlatex.github.io/zh/)UPDATE:
4. Update the default engine from
xelatex
tolualatex
5. Remove the unnecessary reference to
xeCJK
package