Visual fixes on the 'Create new lesson' page #13133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
around the description input. This was caused by -1em margin left being applied to all textboxes instead of only the title box. This fix ensures that this style is applied to the title box only, and only on large screens. On smaller screens it would cause issues with lack of space between the input and icon.
github-actions
bot
added
APP: Coach
Build Artifacts
|
|
cc @jtamiace do the screenshots after look okay? In the bugbash, we weren't 100% sure about the description field taking the whole width, however it seemed to be the only behavior that looked reasonable enough we could think of. |
|
It looks better; this is what I'm seeing on the demo server right now. Not sure if something happened along the way for 0.18 but I think returning it to this state would work. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes width and spacing of inputs on the Create new lesson page. See commit messages.
References
Sub-task of #13127
Reviewer guidance