Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement quiz resources selection switching mode #13123

Merged

Conversation

AlexVelezLl
Copy link
Member

@AlexVelezLl AlexVelezLl commented Feb 26, 2025

Summary

  • Implement quiz resources selection switching mode logic
  • Add button to change the selection mode within the exercise preview
  • Fixes missing coreString value in ResourcePreview
Compartir.pantalla.-.2025-02-26.15_59_37.mp4

References

Closes #13015.

Reviewer guidance

  • With random selection mode, select resources to add to a quiz, then change the selection mode to manual
  • With manual selection mode, select questions to add to a quiz, then change the selection mode to quiz
  • Play combining different possibilities and using the questions settings page and the selection mode checkbox in the exercise preview.

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Feb 26, 2025
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, @AlexVelezLl - it looks like it aligns with the figma well, and the code seems fine to me. I think the best way to really get a feel for this (and if there are any edge cases that we haven't thought of) will be for it to be merged and tried out in the alpha release. Thanks for the quick work here :)

@marcellamaki marcellamaki merged commit 7d029ac into learningequality:develop Feb 27, 2025
36 checks passed
@AlexVelezLl AlexVelezLl deleted the impl-switching-modes branch February 27, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants