Fix lesson resource selection issues #13085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Coach
Build Artifacts
|
pcenov
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Hi @AlexVelezLl - I confirm that the Search button is no longer duplicated and that the already added resources are displayed as preselected in the search results.
The only note I have is that it should be further discussed whether the Search button should be positioned next to the 'Select from bookmarks' or next to the 'Select from channels" label as it could be confusing to some users whether it applies to searching within the bookmarks or within the available channels.
rtibbles
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes duplicated Search button
Disable checkboxes of already selected resources in search results
References
Closes #13074
Closes #13072
Reviewer guidance
Follow instructions in #13074 and #13072