Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ability to preview non-practice resources from the sidepanel #13012
Adds ability to preview non-practice resources from the sidepanel #13012
Changes from 18 commits
354210c
3e9af27
11f8aff
2d76509
77a89c6
ab27f25
7f6e46b
4d18179
331ab80
4f0168e
f13e79f
f95c046
89a99e8
406f138
ebb7e9d
b27e41f
f19ef0b
575f3c3
550973a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is null then will loading be true indefinitely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I see! if
node
is null, theloading.value
will remain true indefinitely because the condition to setloading.value = false
is only executed whennode
is notnull.
I can can see an infinite loading state here. Thanks for pointing that outThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure
node
can ever benull
here - I don't think our api resource methods likefetchModel
would return anything besides the data it gets from the API request or it throws an error.So, in this case, I think you'd probably want to just treat your
then()
callback function as if it's exactly what you expected to get.Then you can chain a catch method on it - but you'll need a way to tell the caller of
useFetchContentNode
to tell the Vue component it is used in that there were errors.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking note. You could skip making the function
fetchContentNode
altogether and just run the code within it directly since you're not returning the function from the composable and you call it within the comopsable.