Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate search resource selection #13008
Integrate search resource selection #13008
Changes from all commits
04ffcbb
fc945b4
3e8d6a5
ee35e76
74857ee
e960ff2
6734671
aed4dcc
32a75be
41353ff
8d5f8bb
569dace
edf6801
65bc654
b936e25
696cfa9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be reduced just to
hasMore: computed(() => useSearchObject.more.value)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ozer550! In this case its not the same, because
hasMore
should be a boolean value, anduseSearchObject.more.value
is an object, the "more" object. So to transform it to boolean we can do either!!useSearchObject.more.value
orBoolean(useSearchObject.more.value)
, but personally I like more the former 😅.