Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visual Testing] Allow object component rendering and unmount previoius component on render #937

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[Visual Testing] Allow object component rendering and unmount previoius component on render #937

wants to merge 2 commits into from
+65 −10

Conversation

AlexVelezLl
Copy link
Member

Description

This PR:

  • Allow object components in the renderComponent method. This way we can render a custom test component withouth needing to register it in Vue.
  • Clears the previous component that was rendered to clear context of previous test runs.

Changelog

  • Description: Allow object component rendering and unmount previoius component on render
  • Products impact: internal
  • Addresses: .
  • Components: .
  • Breaking:
  • Impacts a11y:
  • Guidance:

@AlexVelezLl AlexVelezLl mentioned this pull request Feb 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjester bjester Awaiting requested review from bjester

@MisRob MisRob Awaiting requested review from MisRob

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AlexVelezLl