Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VISUAL TEST FOR KBREADCRUMBS #936

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

RONAK-AI647
Copy link
Contributor

Description

Changelog

  • Description: Visual Test for KBreadcrumbs
  • Products impact: no
  • Addresses: Issue-924
  • Components: KBreadcrumbs
  • Breaking: no
  • Impacts a11y: no
  • Guidance: Visual Test using Percy

KBreadcrumbs should have visual tests to cover at least these snapshots:

1)Breadcrumbs with just one item (with/without showSingleItem).
2)Breadcrumbs with multiple items that do not overflow the available width.
3)Breadcrumbs with multiple items that overflow the available width.
4)Breadcrumbs with multiple items that have long text.
5)Breadcrumbs with links.
6)Dropdown open for overflowed breadcrumbs with links.
7)Dropdown open for overflowed breadcrumbs without links.

(optional) Implementation notes

At a high level, how did you implement this?

Does this introduce any tech-debt items?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Comments

@RONAK-AI647
Copy link
Contributor Author

There is one change which I have postponed right now , that is changing the Kbreadcrumbs.vue to index.vue .......Soon with the first review , I will commit that too...Thank You.

@MisRob
Copy link
Member

MisRob commented Feb 12, 2025

Hi @RONAK-AI647, thank you.

There is one change which I have postponed right now , that is changing the Kbreadcrumbs.vue to index.vue .......Soon with the first review , I will commit that too...Thank You.

No problem, let us know when it's ready and I will then add reviewers.

@RONAK-AI647
Copy link
Contributor Author

Hey @AlexVelezLl , May I get a review , I commited few more errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants