-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VISUAL TEST FOR KBREADCRUMBS #936
base: develop
Are you sure you want to change the base?
VISUAL TEST FOR KBREADCRUMBS #936
Conversation
…adcrumbs.vue to index.vue
There is one change which I have postponed right now , that is changing the Kbreadcrumbs.vue to index.vue .......Soon with the first review , I will commit that too...Thank You. |
Hi @RONAK-AI647, thank you.
No problem, let us know when it's ready and I will then add reviewers. |
Hey @AlexVelezLl , May I get a review , I commited few more errors. |
Description
Changelog
KBreadcrumbs should have visual tests to cover at least these snapshots:
1)Breadcrumbs with just one item (with/without showSingleItem).
2)Breadcrumbs with multiple items that do not overflow the available width.
3)Breadcrumbs with multiple items that overflow the available width.
4)Breadcrumbs with multiple items that have long text.
5)Breadcrumbs with links.
6)Dropdown open for overflowed breadcrumbs with links.
7)Dropdown open for overflowed breadcrumbs without links.
(optional) Implementation notes
At a high level, how did you implement this?
Does this introduce any tech-debt items?
Testing checklist
Reviewer guidance
Comments