Add validation for JSON-formatted tags #3688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkbrum
reviewed
Oct 27, 2023
There was a problem hiding this comment.
The red alert box at the top of the tag settings pages that says "Please be aware that these settings can be very sensitive and there are currently no warnings or blocks in place to prevent you from providing incorrect values" isn't technically correct now-- should we change "no warnings" to "few warnings"?
hwatheod
approved these changes
Nov 20, 2023
willgearty
added a commit
that referenced
this pull request
Jan 5, 2024
* Docs for #3670, #3672, #3671, and #3676 * Docs for #3677, #3673, #3681, and #3683 * Docs for #3682, #3678, #3684, and 74b7e0f * Docs for 74b7e0f, #3685, #3687, and #3686 * Docs for #3688, #3694, #3695, #3692, and #3691 * Docs for #3642, #3696, #3697, and #3700 * change date and add customized buttons for bigpicture * add theme help text --------- Co-authored-by: Katherine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds validation to all existing tags that require a JSON-formatted string (if they are set through the tag settings interface).
Fixes #2084.