Adjust test where all items are negative #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the expected solution of the test when all items are negative to equal the maximum element. In the case of the provided array, the answer would be -1. This aligns with how the question is phrased, and is often represented on algorithm sites. Also change the input array so that the maximum element is a middle element. This accounts for solutions that set the initial maximum to the first element of the input array. An alternate solution would be to change the wording of the problem to only allow for sums above or equal to zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the expected solution of the test when all items are negative to
equal the maximum element. In the case of the provided array, the answer
would be -1. This aligns with how the question is phrased, and is often
represented on algorithm sites.
Also change the input array so that the maximum element is a middle
element. This accounts for solutions that set the initial maximum to the
first element of the input array.
An alternate solution would be to change the wording of the problem to
only allow for sums above or equal to zero.
#4