Adjust input array for Big O test case #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase number of elements in input array from 1000 to 10000. Previously benchmarks showed that an input array of 1000 elements was too small to make a simple nested for loop structure (that is to say, a Big O(n ^2) time complexity) time out. The increase to 10000 not only makes the test fail as intended, but gives padding to account for more powerful machines running the tests inherently faster. The previous code also shows a comment that seems to show the tests were intended to equal 10000, which makes it seem as if 10000 was the intended value all along.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase number of elements in input array from 1000 to 10000.
Previously benchmarks showed that an input array of 1000 elements was
too small to make a simple nested for loop structure (that is to say, a
Big O(n ^2) time complexity) time out. The increase to 10000 not only
makes the test fail as intended, but gives padding to account for more
powerful machines running the tests inherently faster.
The previous code also shows a comment that seems to show the tests
were intended to equal 10000, which makes it seem as if 10000 was the
intended value all along.
#2