Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-38 Add internationalization (i18n) to shift all the ui constants to a language specific JSON file #39

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

sanjevShakya
Copy link

@sanjevShakya sanjevShakya commented May 13, 2020

  • Use of reacti18next
  • Example translation code in login component
  • translation in en>translation.json (default translation namespace for react-i18n)

Note: Key difference between react-intl and react-i18next are

  1. Keys cannot be nested in JSON file.
  2. Have out of the box lazy-load feature to import different translation files
  3. Have the ability to change the language with simple provided function
  4. Have the ability to turn debug on/off and provides if the translations are missing in the console.

closes #38

@sanjevShakya sanjevShakya added the enhancement New feature or request label May 13, 2020
@sanjevShakya sanjevShakya self-assigned this May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add internationalization (i18n) to shift all the ui constants to a language specific JSON file
1 participant