Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update bridge and operator abis #281

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

troggy
Copy link
Member

@troggy troggy commented Jun 19, 2019

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #281 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #281   +/-   ##
=======================================
  Coverage   94.57%   94.57%           
=======================================
  Files          62       62           
  Lines         922      922           
  Branches      173      173           
=======================================
  Hits          872      872           
  Misses         46       46           
  Partials        4        4
Impacted Files Coverage Δ
src/abis/bridgeAbi.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 318c4e4...995ad8c. Read the comment docs.

@troggy
Copy link
Member Author

troggy commented Jun 19, 2019

Not needed anymore (no changes except dropped ExitStartedV2 which we rather keep in ABI for compatibility)

@troggy troggy closed this Jun 19, 2019
@troggy troggy deleted the feat/newest-bridge-and-operator-abis branch June 19, 2019 17:13
@troggy troggy restored the feat/newest-bridge-and-operator-abis branch June 19, 2019 17:15
@troggy troggy reopened this Jun 19, 2019
@troggy
Copy link
Member Author

troggy commented Jun 19, 2019

verified this PR with contract changes all together leapdao/leap-contracts#204, leapdao/leap-contracts#205, leapdao/leap-contracts#206

Procedure:

deployed leap-contracts from master (before the changes)
ran leap-node with updated ABIs
setValidator
deposit some money on plasma
push till next period
do exit (deposit exit)
deposit more
make a transfer
push till next period
do exit (normal exit)
upgrade Bridge and ExitHandler contracts
deposit
push till next period
do exit (deposit exit)
deposit
transfer
push till next period
try to exit (normal exit)

@troggy troggy requested a review from johannbarbie June 19, 2019 18:02
@troggy troggy force-pushed the feat/newest-bridge-and-operator-abis branch from 0192954 to 995ad8c Compare June 19, 2019 18:04
@troggy troggy merged commit 57fb9da into master Jun 20, 2019
@troggy troggy deleted the feat/newest-bridge-and-operator-abis branch June 20, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant