This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - refactor(ring_theory/graded_algebra): use add_submonoid_class to generalize to graded rings
#14583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neralize to graded rings Now tha twe have `add_submonoid_class`, we don't need to consider only families of submodules. For convenience, this keeps around `graded_algebra` as an alias for `graded_ring` over a family of submodules, as this can help with elaboration here and there.
eric-wieser
added
awaiting-review
2 tasks
github-actions
bot
removed
the
awaiting-CI
…ect sum This is a constructive version of `direct_sum.is_internal`, and generalizes the existing `graded_algebra`.
mathlib-dependent-issues-bot
added
the
blocked-by-other-PR
|
I've merged in #14626. |
mathlib-dependent-issues-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on: |
Vierkantor
added
awaiting-author
|
bors r+ |
github-actions
bot
added
ready-to-merge
|
bors r- Looks like this master didn't merge cleanly into this |
|
Canceled. |
|
bors merge So much for deterministic, an empty commit fixed the timeout |
bors bot
pushed a commit
that referenced
this pull request
Jun 29, 2022
…neralize to graded rings (#14583) Now that we have `add_submonoid_class`, we don't need to consider only families of submodules. For convenience, this keeps around `graded_algebra` as an alias for `graded_ring` over a family of submodules, as this can help with elaboration here and there. This renames: * `graded_algebra` to `graded_ring` * `graded_algebra.proj_zero_ring_hom` to `graded_ring.proj_zero_ring_hom` adds: * `direct_sum.decompose_ring_equiv` * `graded_ring.proj` * `graded_algebra` (as an alias for a suitable `graded_ring` and removes: * `graded_algebra.is_internal`, which was just an alias anyway. Co-authored-by: Jujian Zhang <[email protected]>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
add_submonoid_class to generalize to graded ringsadd_submonoid_class to generalize to graded rings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have
add_submonoid_class, we don't need to consider only families of submodules.For convenience, this keeps around
graded_algebraas an alias forgraded_ringover a family of submodules, as this can help with elaboration here and there.This renames:
graded_algebratograded_ringgraded_algebra.proj_zero_ring_homtograded_ring.proj_zero_ring_homadds:
direct_sum.decompose_ring_equivgraded_ring.projgraded_algebra(as an alias for a suitablegraded_ringand removes:
graded_algebra.is_internal, which was just an alias anyway.