Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention tactic state in README #63

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

lambdaofgod
Copy link
Contributor

It might be useful to avoid confusion like in #62

@bustercopley
Copy link
Contributor

Did you notice that the keybinding is already mentioned, in the "Key Bindings and Commands" section of README.txt?

@lambdaofgod
Copy link
Contributor Author

Yes.

That's not the point though - as a first time user I didn't know what command should I run. I'd wager I'm not the only person who faced this problem.

@bustercopley
Copy link
Contributor

bustercopley commented Apr 28, 2024

A new user might not know what "show tactic state" means, either. Can you write something a bit longer, that will make the user think it is something they should try, and give them a clue about what will happen?

By the way, in VS Code, and in the video you linked in #62, "Tactic state" is a section heading, not the name of the tab/pane. In Emacs the buffer's name is *Lean Goals*, and the corresponding section heading is "Goals". I think we should talk about "showing the infoview".

Copy link
Contributor

@bustercopley bustercopley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

README.md Outdated Show resolved Hide resolved
Co-authored-by: Richard Copley <[email protected]>
@lambdaofgod
Copy link
Contributor Author

While we're at it, maybe add a screenshot so people would see how it should look like? WDYT?

@bustercopley
Copy link
Contributor

Maybe in a separate PR? I'm hesitant though, because the maintainers don't put much time into this repo and my guess is that easy, uncontroversial changes have a better chance of getting merged.

I don't know, maybe I'm being overcautious. @urkud?

@urkud
Copy link
Member

urkud commented Apr 30, 2024

I can review PRs on weekends and sometimes in the evening. Please ping me on zulip (mention or dm) when the pr is ready for review.

@urkud urkud merged commit 60d066f into leanprover-community:master Apr 30, 2024
1 of 2 checks passed
sebeaumont pushed a commit to sebeaumont/lean4-mode that referenced this pull request Aug 15, 2024
* mention tactic state in README

* PR suggested edits

* Update README.md

Co-authored-by: Richard Copley <[email protected]>

---------

Co-authored-by: Richard Copley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants