-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mention tactic state in README #63
Conversation
Did you notice that the keybinding is already mentioned, in the "Key Bindings and Commands" section of README.txt? |
Yes. That's not the point though - as a first time user I didn't know what command should I run. I'd wager I'm not the only person who faced this problem. |
A new user might not know what "show tactic state" means, either. Can you write something a bit longer, that will make the user think it is something they should try, and give them a clue about what will happen? By the way, in VS Code, and in the video you linked in #62, "Tactic state" is a section heading, not the name of the tab/pane. In Emacs the buffer's name is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!
Co-authored-by: Richard Copley <[email protected]>
While we're at it, maybe add a screenshot so people would see how it should look like? WDYT? |
Maybe in a separate PR? I'm hesitant though, because the maintainers don't put much time into this repo and my guess is that easy, uncontroversial changes have a better chance of getting merged. I don't know, maybe I'm being overcautious. @urkud? |
I can review PRs on weekends and sometimes in the evening. Please ping me on zulip (mention or dm) when the pr is ready for review. |
* mention tactic state in README * PR suggested edits * Update README.md Co-authored-by: Richard Copley <[email protected]> --------- Co-authored-by: Richard Copley <[email protected]>
It might be useful to avoid confusion like in #62