Fixing notes persistence

leandroBorgesFerreira · Jul 4, 2023 · cfed95c · cfed95c
1 parent 0bf3a36
commit cfed95c
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 3 deletions.
diff --git a/...mple/src/main/java/br/com/leandroferreira/app_sample/screens/note/NoteDetailsViewModel.kt b/...mple/src/main/java/br/com/leandroferreira/app_sample/screens/note/NoteDetailsViewModel.kt
@@ -93,7 +93,9 @@ class NoteDetailsViewModel(
     fun saveNote() {
         viewModelScope.launch {
             val stories = story.value.stories
-            val document = _documentState.value ?: return@launch
+            val document = _documentState.value ?: throw IllegalStateException(
+                "Trying to save a null document, did you forget to create a note?"
+            )
 
             if (stories.noContent()) {
                 documentRepository.deleteDocument(document)

diff --git a/.../src/main/java/com/github/leandroborgesferreira/storyteller/manager/StoryTellerManager.kt b/.../src/main/java/com/github/leandroborgesferreira/storyteller/manager/StoryTellerManager.kt
@@ -389,7 +389,6 @@ class StoryTellerManager(
     }
 
     private fun cancelSelection() {
-        Log.d("Manager", "Cancelling selection")
         _positionsOnEdit.value = emptySet()
     }
 

diff --git a/...ain/java/com/github/leandroborgesferreira/storyteller/utils/extensions/StoryExtensions.kt b/...ain/java/com/github/leandroborgesferreira/storyteller/utils/extensions/StoryExtensions.kt
@@ -12,7 +12,7 @@ fun <T> Iterable<T>.associateWithPosition(): Map<Int, T> {
 }
 
 fun Map<Int, StoryStep>.noContent(): Boolean =
-    this.values.any { storyStep ->
+    this.values.all { storyStep ->
         storyStep.run {
             url.isNullOrBlank() &&
                     path.isNullOrBlank() &&

diff --git a/...va/com/github/leandroborgesferreira/storyteller/utils/extensions/StoryExtensionsKtTest.kt b/...va/com/github/leandroborgesferreira/storyteller/utils/extensions/StoryExtensionsKtTest.kt
@@ -1,6 +1,8 @@
 package com.github.leandroborgesferreira.storyteller.utils.extensions
 
+import androidx.compose.runtime.toMutableStateMap
 import com.github.leandroborgesferreira.storyteller.model.story.StoryStep
+import junit.framework.TestCase.assertFalse
 import junit.framework.TestCase.assertTrue
 import org.junit.Test
 
@@ -16,4 +18,17 @@ class StoryExtensionsKtTest {
 
         assertTrue(storyStepMap.noContent())
     }
+
+    @Test
+    fun `it should be able to recognize a not empty document`() {
+        val storyStepMap = buildList {
+            repeat(5) { index ->
+                add(index to StoryStep(type = "message"))
+            }
+        }.toMutableStateMap()
+
+        storyStepMap[5] = StoryStep(type = "message", text = "some text")
+
+        assertFalse(storyStepMap.noContent())
+    }
 }