Add some fixme comments for later

leancodepl · Nov 19, 2024 · 3c0109e · 3c0109e
1 parent 795ad75
commit 3c0109e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/.../Sources/video_player_avfoundation/include/video_player_avfoundation/FVPNativeVideoView.h b/.../Sources/video_player_avfoundation/include/video_player_avfoundation/FVPNativeVideoView.h
@@ -4,6 +4,9 @@
 #import <Flutter/Flutter.h>
 #endif
 
+// FIXME Do we even need ifs below? MacOS currently doesn't support FlutterPlatformView.
+//  But can we complie code without it? And is it good to put iOS-specific code in the main
+//  directory (video_player_avfoundation?
 #if TARGET_OS_OSX
 @interface FVPNativeVideoView : NSView
 #else

diff --git a/...deo_player_avfoundation/include/video_player_avfoundation/FVPVideoPlayerTextureApproach.h b/...deo_player_avfoundation/include/video_player_avfoundation/FVPVideoPlayerTextureApproach.h
@@ -2,6 +2,7 @@
 #import "FVPFrameUpdater.h"
 #import "FVPVideoPlayer.h"
 
+// FIXME Add docs - what functionality this class adds.
 @interface FVPVideoPlayerTextureApproach : FVPVideoPlayer
 // The CALayer associated with the Flutter view this plugin is associated with, if any.
 @property(nonatomic, readonly) CALayer *flutterViewLayer;

diff --git a/...rwin/video_player_avfoundation/Sources/video_player_avfoundation_ios/FVPNativeVideoView.m b/...rwin/video_player_avfoundation/Sources/video_player_avfoundation_ios/FVPNativeVideoView.m
@@ -2,6 +2,7 @@
 
 #import "FVPNativeVideoView.h"
 
+// FIXME Add some docs for FVPNativeVideoView and possibly FVPPlayerView
 @interface FVPPlayerView : UIView
 @end
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,6 +2,7 @@ @@
     #import "FVPNativeVideoView.h"
+    // FIXME Add some docs for FVPNativeVideoView and possibly FVPPlayerView
     @interface FVPPlayerView : UIView
     @end
@@ Expand Down @@