This repository has been archived by the owner on Jul 2, 2019. It is now read-only.
修复一系列测试提出的Bug； #323
Open
修复一系列测试提出的Bug； #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢你的贡献！我们 review 一下这个 PR。 |
tang3w
reviewed
Jul 6, 2017
| } | ||
| } | ||
|
|
||
| - (BOOL)JudgeAVAudioSession { |
tang3w
reviewed
Jul 6, 2017
| - (BOOL)JudgeAVAudioSession { | ||
| __block BOOL bCanRecord = YES; | ||
| AVAudioSession *audioSession = [AVAudioSession sharedInstance]; | ||
| if ([audioSession respondsToSelector:@selector(requestRecordPermission:)]) { |
There was a problem hiding this comment.
ChatKit 支持 iOS 7 及以上，-[AVAudioSession requestRecordPermission:] 在 iOS 7 上是可用的，可以直接调用。
tang3w
reviewed
Jul 6, 2017
| @@ -45,6 +45,7 @@ @interface LCCKChatBar () <UITextViewDelegate, UINavigationControllerDelegate, M | |||
| @property (assign, nonatomic) CGFloat oldTextViewHeight; | |||
| @property (nonatomic, assign, getter=shouldAllowTextViewContentOffset) BOOL allowTextViewContentOffset; | |||
| @property (nonatomic, assign, getter=isClosed) BOOL close; | |||
| @property (nonatomic, assign) BOOL outTime;//是否超时 | |||
There was a problem hiding this comment.
是不是用 timeout / timedOut / isTimedOut 之类的作为属性名更好？
|
@tang3w ChaiKit中有没有什么可以直接用的提醒 我在工程中 Development Pods里想加一个纯文本的提醒 其他的提醒好像都在Example中 |
tang3w
reviewed
Jul 7, 2017
| @@ -664,6 +714,10 @@ - (void)sendTextMessage:(NSString *)text{ | |||
| if (!text || text.length == 0 || [text lcck_isSpace]) { | |||
| return; | |||
| } | |||
| if (text.length > 1000) { | |||
There was a problem hiding this comment.
您好，请把这个数字作为一个常量，放在 LCCKConstants.h 中，例如：
static const NSUInteger kLCCKMessageMaxTextLength = 1000;
然后在 alert 中也用这个常量来构造提示信息。
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My issue:
仍然有一个发送超级长的文本会失败的问题，目前在本地做了控制不能超过300字，希望Leancloud可以有更好的方案
What I have done:
目前优化了60S录音的超时处理；增加了1S录音的后续处理；增加了录音过程中切换后台返回前台异常的问题；1S以内提示录音失败改为了提示时间太短；