-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove Default Resolver + GQL Dataloaders #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Use get_list in doc-dataloader feat: Basic Perms for new resolvers Co-authored-by: Fahim Ali Zain <[email protected]> Merge-request: ROMMAN-MR-126 Merged-by: Fahim Ali Zain <[email protected]>
* feat: Field Level Perms * fix: keywords in field names
Co-authored-by: Fahim Ali Zain <[email protected]> Merge-request: ROMMAN-MR-178 Merged-by: Fahim Ali Zain <[email protected]>
fix: remove redundant resolver check Merge branch 'ROMMAN-T-289-kick-default-resolver' into ROMMAN-T-481-translations feat: Translations Support Co-authored-by: Fahim Ali Zain <[email protected]> Merge-request: ROMMAN-MR-177 Merged-by: Fahim Ali Zain <[email protected]>
Co-authored-by: Abadulrehman <[email protected]> Merge-request: ROMMAN-MR-196 Merged-by: Fahim Ali Zain <[email protected]>
fahimalizain
force-pushed
the
ROMMAN-T-289-kick-default-resolver
branch
from
August 26, 2022 11:47
ede2360
to
ea01ae7
Compare
…el Restricted Fields fix: check for GraphQLNonNull fix: use default_field_resolver from graphql fix: refactored perm checks fix: Raise Perm Error on GQLNonNull Permlevel Restricted Fields Co-authored-by: Fahim Ali Zain <[email protected]> Merge-request: ROMMAN-MR-214 Merged-by: Fahim Ali Zain <[email protected]>
* refactor: use graphql-sync-dataloader package * refactor: update package graphql-sync-dataloader
tests: fix test_deleted_doc_resolution Merge branch 'ROMMAN-T-289-kick-default-resolver' into ROMMAN-T-433-document-resolver-tests Merge branch 'ROMMAN-T-289-kick-default-resolver' into ROMMAN-T-433-document-resolver-tests tests: Update DocumentResolver Tests Co-authored-by: Fahim Ali Zain <[email protected]> Merge-request: ROMMAN-MR-368 Merged-by: Fahim Ali Zain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two optimizations done here.
Fixes #53