Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RfC: migrate to Typescript, enable tree shaking #412

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

simon04
Copy link
Contributor

@simon04 simon04 commented Nov 19, 2021

When only requiring one or two layers, leaflet-providers is overkill since it weights 22.9 kB

To improve on that I'd like to suggest/discuss:

  • export provider definitions such as OpenStreetMap or Esri as separate modules
  • pass one of those provider definitions in the layer constructor
  • migrate to TypeScript
  • use esbuild for bundling

I'm happy to hear your thoughts!

@brunob
Copy link
Member

brunob commented Nov 19, 2021

Thx for the PR, i'm totally out of TypeScript things, let's wait for @jieter thought on this...

@brunob
Copy link
Member

brunob commented Aug 31, 2022

bump @jieter personally this change would push me out of the project.

@vincerubinetti
Copy link
Contributor

It would help if there was a least a declaration file in the repo. There seems to be a @types/leaflet-providers definition, though I can't get TS to recognize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants