Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TARGET_LINKER_FILE/TARGET_LINKER_FILE_NAME with SpoutLibrary #97

Closed
wants to merge 1 commit into from
Closed

Use TARGET_LINKER_FILE/TARGET_LINKER_FILE_NAME with SpoutLibrary #97

wants to merge 1 commit into from

Conversation

scribam
Copy link

@scribam scribam commented Aug 5, 2023

https://cmake.org/cmake/help/v3.27/manual/cmake-generator-expressions.7.html#genex:TARGET_LINKER_FILE

$<TARGET_LINKER_FILE:tgt>
File used when linking to the tgt target. This will usually be the library that tgt represents (.a, .lib, .so), but for a shared library on DLL platforms, it would be the .lib import library associated with the DLL.

Fix MINGW which generates a file named libSpoutLibrary.dll.a and not SpoutLibrary.lib

@leadedge
Copy link
Owner

leadedge commented Aug 6, 2023

I understand the change but I am not sure what effect this might have on PR #64 for single config generators support by @jockekilby. Could you explain a little more about that.

@jockekilby
Copy link

I haven't had a chance to test it but I don't believe this change would have any impact on the functionality I introduced in this commit, but the changes should be made for theSpotGL project as well?

@leadedge
Copy link
Owner

leadedge commented Aug 7, 2023

Thanks very much @jockekilby . I think this is should be a useful addition by @scribam. What I think I will do is make the changes by hand with the original commented out just in case. I will look at SpoutGL as well. I will be busy for a few days but will do so as soon as I can.

@jockekilby
Copy link

ok, let me know if you require assistance 😄

@leadedge
Copy link
Owner

leadedge commented Aug 9, 2023

I made the proposed changes and left the old code as comments for reference. I am not sure that the SpoutGL project file needs to be changed since there are independent name definitions already.

@leadedge leadedge closed this Aug 9, 2023
@scribam scribam deleted the target-linker branch August 9, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants