Apply suggestions from code review

Co-authored-by: Daniel Arndt <[email protected]>
ldh4 · Sep 11, 2024 · f332a8a · f332a8a
1 parent 299ce02
commit f332a8a
Show file tree

Hide file tree

Showing 6 changed files with 29 additions and 29 deletions.
diff --git a/core/src/Cuda/Kokkos_Cuda_Team.hpp b/core/src/Cuda/Kokkos_Cuda_Team.hpp
@@ -526,7 +526,7 @@ parallel_reduce(const Impl::TeamThreadRangeBoundariesStruct<
            ReducerType, value_type>;
        using wrapped_reducer_type = typename functor_analysis_type::Reducer;
 
-       wrapped_reducer_type wrapped_reducer(reducer); value_type value{};
+       wrapped_reducer_type wrapped_reducer(reducer); value_type value;
        wrapped_reducer.init(&value);
 
        for (iType i = loop_boundaries.start + threadIdx.y;
@@ -604,7 +604,7 @@ parallel_reduce(const Impl::TeamVectorRangeBoundariesStruct<
            ReducerType, value_type>;
        using wrapped_reducer_type = typename functor_analysis_type::Reducer;
 
-       wrapped_reducer_type wrapped_reducer(reducer); value_type value{};
+       wrapped_reducer_type wrapped_reducer(reducer); value_type value;
        wrapped_reducer.init(&value);
 
        for (iType i =
@@ -641,7 +641,7 @@ parallel_reduce(const Impl::TeamVectorRangeBoundariesStruct<
        using wrapped_reducer_type = typename functor_analysis_type::Reducer;
        using value_type           = typename wrapped_reducer_type::value_type;
 
-       wrapped_reducer_type wrapped_reducer(closure); value_type value{};
+       wrapped_reducer_type wrapped_reducer(closure); value_type value;
        wrapped_reducer.init(&value);
 
        for (iType i =
@@ -707,7 +707,7 @@ parallel_reduce(Impl::ThreadVectorRangeBoundariesStruct<
           ReducerType, value_type>;
       using wrapped_reducer_type = typename functor_analysis_type::Reducer;
 
-      wrapped_reducer_type wrapped_reducer(reducer); value_type value{};
+      wrapped_reducer_type wrapped_reducer(reducer); value_type value;
       wrapped_reducer.init(&value);
 
       for (iType i = loop_boundaries.start + threadIdx.x;
@@ -754,7 +754,7 @@ parallel_reduce(Impl::ThreadVectorRangeBoundariesStruct<
       using wrapped_reducer_type = typename functor_analysis_type::Reducer;
       using value_type           = typename wrapped_reducer_type::value_type;
 
-      wrapped_reducer_type wrapped_reducer(closure); value_type value{};
+      wrapped_reducer_type wrapped_reducer(closure); value_type value;
       wrapped_reducer.init(&value);
 
       for (iType i = loop_boundaries.start + threadIdx.x;

diff --git a/core/src/HIP/Kokkos_HIP_Team.hpp b/core/src/HIP/Kokkos_HIP_Team.hpp
@@ -519,7 +519,7 @@ parallel_reduce(const Impl::TeamThreadRangeBoundariesStruct<
   using wrapped_reducer_type = typename functor_analysis_type::Reducer;
 
   wrapped_reducer_type wrapped_reducer(reducer);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
   for (iType i = loop_boundaries.start + threadIdx.y; i < loop_boundaries.end;
@@ -559,7 +559,7 @@ parallel_reduce(const Impl::TeamThreadRangeBoundariesStruct<
        using wrapped_reducer_type = typename functor_analysis_type::Reducer;
        using value_type           = typename wrapped_reducer_type::value_type;
 
-       wrapped_reducer_type wrapped_reducer(closure); value_type value{};
+       wrapped_reducer_type wrapped_reducer(closure); value_type value;
        wrapped_reducer.init(&value);
 
        for (iType i = loop_boundaries.start + threadIdx.y;
@@ -671,7 +671,7 @@ parallel_reduce(const Impl::TeamVectorRangeBoundariesStruct<
   using wrapped_reducer_type = typename functor_analysis_type::Reducer;
 
   wrapped_reducer_type wrapped_reducer(reducer);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
   for (iType i = loop_boundaries.start + threadIdx.y * blockDim.x + threadIdx.x;
@@ -703,7 +703,7 @@ parallel_reduce(const Impl::TeamVectorRangeBoundariesStruct<
        using wrapped_reducer_type = typename functor_analysis_type::Reducer;
        using value_type           = typename wrapped_reducer_type::value_type;
 
-       wrapped_reducer_type wrapped_reducer(closure); value_type value{};
+       wrapped_reducer_type wrapped_reducer(closure); value_type value;
        wrapped_reducer.init(&value);
 
        for (iType i =
@@ -769,7 +769,7 @@ parallel_reduce(Impl::ThreadVectorRangeBoundariesStruct<
   using wrapped_reducer_type = typename functor_analysis_type::Reducer;
 
   wrapped_reducer_type wrapped_reducer(reducer);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
   for (iType i = loop_boundaries.start + threadIdx.x; i < loop_boundaries.end;
@@ -812,7 +812,7 @@ parallel_reduce(Impl::ThreadVectorRangeBoundariesStruct<
        using wrapped_reducer_type = typename functor_analysis_type::Reducer;
        using value_type           = typename wrapped_reducer_type::value_type;
 
-       wrapped_reducer_type wrapped_reducer(closure); value_type value{};
+       wrapped_reducer_type wrapped_reducer(closure); value_type value;
        wrapped_reducer.init(&value);
 
        for (iType i = loop_boundaries.start + threadIdx.x;

diff --git a/core/src/HPX/Kokkos_HPX.hpp b/core/src/HPX/Kokkos_HPX.hpp
@@ -1794,7 +1794,7 @@ KOKKOS_INLINE_FUNCTION void parallel_reduce(
   using value_type           = typename wrapped_reducer_type::value_type;
 
   wrapped_reducer_type wrapped_reducer(lambda);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
   for (iType i = loop_boundaries.start; i < loop_boundaries.end;
@@ -1845,7 +1845,7 @@ KOKKOS_INLINE_FUNCTION void parallel_reduce(
   using value_type           = typename wrapped_reducer_type::value_type;
 
   wrapped_reducer_type wrapped_reducer(lambda);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
 #ifdef KOKKOS_ENABLE_PRAGMA_IVDEP
@@ -1873,7 +1873,7 @@ KOKKOS_INLINE_FUNCTION void parallel_reduce(
   using wrapped_reducer_type = typename functor_analysis_type::Reducer;
 
   wrapped_reducer_type wrapped_reducer(reducer);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
   for (iType i = loop_boundaries.start; i < loop_boundaries.end;
@@ -1899,7 +1899,7 @@ KOKKOS_INLINE_FUNCTION void parallel_reduce(
   using wrapped_reducer_type = typename functor_analysis_type::Reducer;
 
   wrapped_reducer_type wrapped_reducer(reducer);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
 #ifdef KOKKOS_ENABLE_PRAGMA_IVDEP

diff --git a/core/src/SYCL/Kokkos_SYCL_Team.hpp b/core/src/SYCL/Kokkos_SYCL_Team.hpp
@@ -563,7 +563,7 @@ parallel_reduce(const Impl::TeamThreadRangeBoundariesStruct<
   using wrapped_reducer_type = typename functor_analysis_type::Reducer;
 
   wrapped_reducer_type wrapped_reducer(reducer);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
   for (iType i = loop_boundaries.start +
@@ -599,7 +599,7 @@ parallel_reduce(const Impl::TeamThreadRangeBoundariesStruct<
   using value_type           = typename wrapped_reducer_type::value_type;
 
   wrapped_reducer_type wrapped_reducer(closure);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
   for (iType i = loop_boundaries.start +
@@ -707,7 +707,7 @@ parallel_reduce(const Impl::TeamVectorRangeBoundariesStruct<
   using wrapped_reducer_type = typename functor_analysis_type::Reducer;
 
   wrapped_reducer_type wrapped_reducer(reducer);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
   const iType tidx0 = loop_boundaries.member.item().get_local_id(0);
@@ -740,7 +740,7 @@ parallel_reduce(const Impl::TeamVectorRangeBoundariesStruct<
   using value_type           = typename wrapped_reducer_type::value_type;
 
   wrapped_reducer_type wrapped_reducer(closure);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
   const iType tidx0 = loop_boundaries.member.item().get_local_id(0);
@@ -815,7 +815,7 @@ parallel_reduce(Impl::ThreadVectorRangeBoundariesStruct<
   using wrapped_reducer_type = typename functor_analysis_type::Reducer;
 
   wrapped_reducer_type wrapped_reducer(reducer);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
   const iType tidx1   = loop_boundaries.member.item().get_local_id(1);
@@ -854,7 +854,7 @@ parallel_reduce(Impl::ThreadVectorRangeBoundariesStruct<
   using value_type           = typename wrapped_reducer_type::value_type;
 
   wrapped_reducer_type wrapped_reducer(closure);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
   const iType tidx1 = loop_boundaries.member.item().get_local_id(1);

diff --git a/core/src/Threads/Kokkos_Threads_Team.hpp b/core/src/Threads/Kokkos_Threads_Team.hpp
@@ -908,7 +908,7 @@ parallel_reduce(const Impl::TeamThreadRangeBoundariesStruct<
   using value_type           = typename wrapped_reducer_type::value_type;
 
   wrapped_reducer_type wrapped_reducer(lambda);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
   for (iType i = loop_boundaries.start; i < loop_boundaries.end;
@@ -934,7 +934,7 @@ parallel_reduce(const Impl::TeamThreadRangeBoundariesStruct<
   using wrapped_reducer_type = typename functor_analysis_type::Reducer;
 
   wrapped_reducer_type wrapped_reducer(reducer);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
   for (iType i = loop_boundaries.start; i < loop_boundaries.end;
@@ -987,7 +987,7 @@ parallel_reduce(const Impl::ThreadVectorRangeBoundariesStruct<
   using value_type           = typename wrapped_reducer_type::value_type;
 
   wrapped_reducer_type wrapped_reducer(lambda);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
   for (iType i = loop_boundaries.start; i < loop_boundaries.end;
@@ -1012,7 +1012,7 @@ parallel_reduce(const Impl::ThreadVectorRangeBoundariesStruct<
   using wrapped_reducer_type = typename functor_analysis_type::Reducer;
 
   wrapped_reducer_type wrapped_reducer(reducer);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
   for (iType i = loop_boundaries.start; i < loop_boundaries.end;

diff --git a/core/src/impl/Kokkos_HostThreadTeam.hpp b/core/src/impl/Kokkos_HostThreadTeam.hpp
@@ -804,7 +804,7 @@ KOKKOS_INLINE_FUNCTION
   using wrapped_reducer_type = typename functor_analysis_type::Reducer;
 
   wrapped_reducer_type wrapped_reducer(reducer);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
   for (iType i = loop_boundaries.start; i < loop_boundaries.end;
@@ -832,7 +832,7 @@ KOKKOS_INLINE_FUNCTION
   using value_type           = typename wrapped_reducer_type::value_type;
 
   wrapped_reducer_type wrapped_reducer(closure);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
   for (iType i = loop_boundaries.start; i < loop_boundaries.end;
@@ -893,7 +893,7 @@ KOKKOS_INLINE_FUNCTION
   using value_type           = typename wrapped_reducer_type::value_type;
 
   wrapped_reducer_type wrapped_reducer(lambda);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
   for (iType i = loop_boundaries.start; i < loop_boundaries.end;
@@ -919,7 +919,7 @@ KOKKOS_INLINE_FUNCTION
   using wrapped_reducer_type = typename functor_analysis_type::Reducer;
 
   wrapped_reducer_type wrapped_reducer(reducer);
-  value_type value{};
+  value_type value;
   wrapped_reducer.init(&value);
 
   for (iType i = loop_boundaries.start; i < loop_boundaries.end;