Skip to content

Commit

Permalink
Fix minor issues found in CI runs
Browse files Browse the repository at this point in the history
  • Loading branch information
lczech committed Oct 28, 2024
1 parent 8f98208 commit b1cc9cf
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,8 @@ if (MSVC OR (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC"))
else ()
# For other operating systems, set the warn flags to a very high level - except unknown pragmas,
# as this causes needless warnings with OpenMP and other pragma-based techniques.
set (WARN_FLAGS "-Wall -Wextra -Wno-unknown-pragmas -pedantic -pedantic-errors")
set( WARN_FLAGS "-Wall -Wextra -pedantic -pedantic-errors" )
set( WARN_FLAGS "${WARN_FLAGS} -Wno-unknown-pragmas -Wno-unknown-attributes" )

# Furthermore, in debug mode, we also want all warnings to be errors, so that we do not miss them
# In release, this might hinder users to successfully build genesis if any warnings remain
Expand Down
2 changes: 1 addition & 1 deletion lib/genesis/utils/math/statistics.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ inline void closure( std::vector<double>& vec )
template <class ForwardIterator>
double shannon_entropy( ForwardIterator first, ForwardIterator last, double log_base = 2.0)
{
using T = ForwardIterator::value_type;
using T = typename ForwardIterator::value_type;

// Use uint64_t for integral types, and compensated summation for floating-point types,
// to avoid overflow, and get maximum accuracy.
Expand Down

0 comments on commit b1cc9cf

Please sign in to comment.