Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overload math degrees and radians to support more ltypes #389

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Overload math degrees and radians to support more ltypes #389

merged 1 commit into from
Apr 18, 2022

Conversation

Aasthaengg
Copy link
Contributor

This PR includes changes to overload degrees and radians functions to support i8, i16, i32, i64, f32, f64 ltypes. Relevant test code is added to test_math.py.

@Aasthaengg
Copy link
Contributor Author

@Smit-create thanks for your suggestion. Could you have a look at it now, please?

Smit-create
Smit-create approved these changes Apr 18, 2022
View reviewed changes
Copy link
Collaborator

@Smit-create Smit-create left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

certik
certik approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that looks good, thanks!

@certik certik merged commit 0e3beae into lcompilers:main Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

@Smit-create Smit-create Smit-create approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aasthaengg @certik @Smit-create