Generalized the library by removing Fortran-specific references resolving issue #554 #2818
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmr-srbh
reviewed
Dec 28, 2024
| | TypeInquiry(int inquiry_id, ttype arg_type, expr? arg, ttype type, expr value) | ||
| | TypeInquiry(int inquiry_id, ttype arg_type, expr? arg, ttype type, expr? value) |
There was a problem hiding this comment.
This change is not correct actually. expr? means a field which is optional and can be set to nullptr. Here, expr? value refers to compile-time value, which can be absent sometimes.
kmr-srbh
reviewed
Dec 28, 2024
| | TupleLen(expr arg, ttype type, expr value) | ||
| | TupleLen(expr arg, ttype type, expr? value) |
|
LPython is a sister project of LFortran and they share a similar ASR design. I think this PR is probably not required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description:
The current implementation of the library contains Fortran-specific references that limit its applicability to environments and languages other than Fortran. Specifically, the abi, tbind, and several other components are tightly coupled to Fortran conventions and terminology, making the library less flexible for use in a broader range of programming languages and systems.
Proposed Solution:
This pull request addresses the issue by removing the Fortran-specific references and generalising the code. The updates ensure that the library can be easily integrated into diverse programming environments. Specifically, changes have been made to the abi, tbind, and other related components, allowing them to support a wider range of language bindings and configurations.
By making these changes, the library becomes more modular and adaptable, improving its portability and making it more suitable for modern, multi-language development environments.
Can you please review this and let me know the changes to be done .Thank you !