-
Notifications
You must be signed in to change notification settings - Fork 171
CI: Use MSVC generator #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Build failure once again. |
But this is a good failure. It now picks up MSVC: -- The C compiler identification is MSVC 19.30.30709.0
-- The CXX compiler identification is MSVC 19.30.30709.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.30.30705/bin/Hostx64/x64/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.30.30705/bin/Hostx64/x64/cl.exe - skipped We just have to fix the actual error now. |
The error is:
I know what that is: we are compiling in debug mode but llvm is compiled in release mode, so it can't be linked together. |
Ok, it built. Now we just need the Release thing. |
Almost. Just the last part of
I think CMake needs updating to generate the runtime library without the Release suffix. |
Now it fails with: $ ci\build.xsh:80:src/bin/lpython -o expr2 expr2.o
link: extra operand 'expr2.o'
Try 'link --help' for more information.
The command 'link /NOLOGO /OUT:expr2 expr2.o D:\a\lpython\lpython\SRC\BIN/../runtime\lfortran_runtime_static.lib' failed. |
I wonder if it might be calling the wrong |
We'll have to port the improvements from this PR over one by one with the older Windows image, that should work. And then we can switch the image and just iron out the path to MSVC. |
Now when |
I am going to leave this open for now. The actual build (excluding the initial package installation) got 2x slower (from about 5 min to 10 min). The main thing we need is to figure out how to update to the latest windows image, so we'll use this PR to help us there, but let's not merge it until we figure out what is going on with the speed, possibly keeping it with Ninja. |
No description provided.