Bugfix: ByteBuffer->equals

lbuchs · Nov 15, 2022 · b57d37f · b57d37f
1 parent de1a694
commit b57d37f
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/Binary/ByteBuffer.php b/src/Binary/ByteBuffer.php
@@ -186,11 +186,18 @@ public function getBinaryString(): string {
     }
 
     /**
-     * @param string $buffer
+     * @param string|ByteBuffer $buffer
      * @return bool
      */
     public function equals($buffer): bool {
-        return is_string($this->_data) && $this->_data === $buffer->data;
+        if (is_object($buffer) && $buffer instanceof ByteBuffer) {
+            return $buffer->getBinaryString() === $this->getBinaryString();
+
+        } else if (is_string($buffer)) {
+            return $buffer === $this->getBinaryString();
+        }
+
+        return false;
     }
 
     /**