Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the instructions in INSTALL.md #3358

Merged
merged 6 commits into from
Jul 19, 2021

Conversation

belikor
Copy link
Contributor

@belikor belikor commented Jul 11, 2021

Because of issue #2769 at the moment the lbrynet daemon will only work correctly with Python 3.7.

The deadsnakes personal package archive (PPA) provides Python 3.7 for Ubuntu distributions that no longer have it in their official repositories like 18.04 and 20.04.

If Python 3.8+ is used, the daemon will start but the RPC server may not accept messages, returning the following:

Could not connect to daemon. Are you sure it's running?

Add more information regarding virtual environments.

Enter the environment with

source lbry-venv/bin/activate

And leave with deactivate.

When developing, we can start the server interactively.

python lbry/extras/cli.py start

belikor added 3 commits July 11, 2021 19:44
Leave with `deactivate`.

Enter the environment again with
```
source lbry-venv/bin/activate
```

When developing, we can start the server interactively.
```
python lbry/extras/cli.py start
```

Parameters can be passed in the same way.
```
python lbry/extras/cli.py wallet balance
```

If a Python debugger (`pdb` or `ipdb`) is installed we can also start
it in this way, set up break points, and step through the code.
```
ipdb lbry/extras/cli.py
```
Because of issue lbryio#2769 at the moment the `lbrynet` daemon
will only work correctly with Python 3.7.

The `deadsnakes` personal package archive (PPA) provides
Python 3.7 for Ubuntu distributions that no longer have it
in their official repositories like 18.04 and 20.04.

If Python 3.8+ is used, the daemon will start but the RPC server
may not accept messages, returning the following:
```
Could not connect to daemon. Are you sure it's running?
```
Remove the first space in the block of code as it is not necessary.

This
 ```
 $ python --version
 ```

Becomes this
```
$ python --version
```

Also break the big block of code into individual blocks.
Copy link
Member

@eukreign eukreign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't currently support Python 3.8 so I'm not sure it makes sense to add to docs instructions on how to setup with it. Let's figure out and fix the issues with SDK on Python 3.8 before offering it in the docs as an option.

@lbry-bot lbry-bot assigned eukreign and unassigned eukreign Jul 19, 2021
@eukreign eukreign assigned belikor and unassigned eukreign Jul 19, 2021
@lyoshenka lyoshenka merged commit be544d6 into lbryio:master Jul 19, 2021
@belikor belikor deleted the improve-install-md branch July 19, 2021 22:36
@belikor
Copy link
Contributor Author

belikor commented Jul 19, 2021

We don't currently support Python 3.8 so I'm not sure it makes sense to add to docs instructions on how to setup with it.

For reference, this pull request does not explain how to set up Python 3.8, it just explicitly mentions that it does not work with Python 3.8. That was my intention.

If the other problems with aiohttp are solved then we can reword this to mention Python 3.7, 3.8, and 3.9.

@eukreign eukreign added area: docs type: improvement Existing (or partially existing) functionality needs to be changed labels Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants