[IconFetcher] Fix ABI compatibility with upstream rofi #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@q234rty plz test if any regressions. |
|
Seems to work fine in my case. |
lbonn
reviewed
Nov 5, 2023
| @@ -1114,14 +1114,21 @@ static gboolean rofi_theme_get_image_inside(Property *p, const widget *widget, | |||
| default: | |||
| break; | |||
| } | |||
| #if 0 | |||
There was a problem hiding this comment.
Do we still need this commented out code?
There was a problem hiding this comment.
I just left it for future reference. If you want I can remove it.
This was referenced Nov 30, 2023
|
@moetayuko I have reworked the changes there #102, please have a look |
|
Closed after #102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96
cc @SabrinaJewson