Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor types and cursor-shape-v1 support #113

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

alebastr
Copy link

@alebastr alebastr commented Jan 8, 2024

  • Support for different cursor types.
    Testable with rofi -theme docu ....
  • Support for compositor-rendered cursors via cursor-shape-v1.
    Requires wlroots >= 0.17 (Sway v1.9 or master branches) and wayland-protocols >= 1.32.
    For an extra rice, do
    seat seat1 {
      attach a-second-pointer-device
      xcursor_theme non-default-theme
    }
    
    and observe two cursors with different themes.

Also fixes #105


With that in place, I was prepared to tackle the final boss, fractional-scale-v1... but my holiday time off has ended.
I'll try to finish it in the next few weeks, but no promises.

@lbonn
Copy link
Owner

lbonn commented Jan 8, 2024

@alebastr
Thanks for looking into this :)!

One thing though, I have tried with two cursors of different sizes and they both get resized to the value of $XCURSOR_SIZE when hovering over rofi. But I guess it's another existing issue?

@alebastr
Copy link
Author

alebastr commented Jan 8, 2024

One thing though, I have tried with two cursors of different sizes and they both get resized to the value of $XCURSOR_SIZE when hovering over rofi. But I guess it's another existing issue?

This works for me with swaywm/sway@2bba8a8 (branch v1.9) and different cursor sizes per seat (seat seat1 xcursor_theme default 36).

With client-rendered cursors, it's an expected behavior to have the same theme/size for all the seats (inherited from the default seat0 at least in Sway), as there's no standard way to pass a per-seat configuration from the compositor. You can check if the cursor-shape-v1 protocol is used with WAYLAND_DEBUG.

@lbonn
Copy link
Owner

lbonn commented Jan 8, 2024

Ah well ok 😁

Thanks!

@lbonn lbonn merged commit b88dddd into lbonn:wayland Jan 8, 2024
4 checks passed
@alebastr alebastr deleted the wayland-cursor-shape branch January 8, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Segmentation fault while moving a cursor to another monitor
2 participants