Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Prettier to the codebase #425

Merged
merged 1 commit into from
May 9, 2024
Merged

Apply Prettier to the codebase #425

merged 1 commit into from
May 9, 2024

Conversation

dkozickis
Copy link
Contributor

Overview

  • Apply Prettier to the codebase
  • Add lint:prettier and lint:prettier:fix scripts in package.json

Cannot use ember-template-lint-plugin-prettier plugin for ember-template-lint because of this issue - ember-template-lint/ember-template-lint-plugin-prettier#268

Setup

  1. Checkout
  2. Try to run pnpm run lint:prettier

Challenges/uncertainties

Do we need to add pre-commit hook that will run prettier:fix on changed files?

Checks PR readiness

  • changelog
  • npm lint

@dkozickis dkozickis enabled auto-merge May 9, 2024 11:25
@dkozickis dkozickis merged commit 825c94d into master May 9, 2024
1 of 3 checks passed
@dkozickis dkozickis deleted the prettier branch May 9, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant