Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct compliance with MSL (maint 9.1) #3985

Merged
merged 5 commits into from
Nov 1, 2024

Conversation

mwetter
Copy link
Member

@mwetter mwetter commented Aug 31, 2024

This is for #3978

@mwetter mwetter self-assigned this Aug 31, 2024
@mwetter mwetter enabled auto-merge (squash) August 31, 2024 02:17
@hcasperfu
Copy link
Contributor

I cannot reproduce the failed tests locally with either 2024xRefresh1 (current version) or 2023x (version marked in CI DYMOLA_VERSON) and I don't have 2025x.

The previous version did not work if the parameter keyword was removed from the function surfaceTemperature (the keyword has to be removed per the MSL definition) because the function assigns this value to a member of the record that is a parameter, which only newer versions of OpenModelica support
@mwetter mwetter merged commit 87b8ef2 into maint_9.1.x Nov 1, 2024
4 checks passed
@mwetter mwetter deleted the maint_9.1.x_issue3978_dymola2025x branch November 1, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants