Added Paragraphs to in-script documentation & Renamed OnDestroyingComponent #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix readme typo
Makes it use the same convention as Unity does. `OnCreated + OnDestroying` versus `OnCreated + OnDestroyed` you could do `OnCreating + OnDestroying ` but that does not follow the naming as unity which users are probably familiar with.
… System. Did that before I understood the IWorldCallbackReceiver.
Passes arguments by reference (ReadOnly). As long as the argument doesn't modify the parameter we can use this to increase performance. https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/in-parameter-modifier (In-Parameter-Modifier)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added paragraphs in the in-code documentation where needed, added some instances of where I felt they would fit.
Renamed OnDestroyingComponent to OnDestroyedComponent so it's more like Unity''s API.
(If you really don't like this part I can undo it and make a new PR)
Change:
