This repository has been archived by the owner on Jun 22, 2022. It is now read-only.
Better form validation #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottharvey
commented
Mar 21, 2020
| <div class="invalid-feedback"> | ||
| <%%= <%= model_resource_name %>.errors[:<%= attribute.column_name %>].to_sentence.humanize %> | ||
| </div> | ||
| <%% end %> |
There was a problem hiding this comment.
Display the error under the form input
scottharvey
commented
Mar 21, 2020
| <% else -%> | ||
| <%%= form.<%= attribute.field_type %> :<%= attribute.column_name %>, class: 'form-control' %> | ||
| <%%= form.<%= attribute.field_type %> :<%= attribute.column_name %>, class: "form-control #{'is-invalid' if <%= model_resource_name %>.errors[:<%= attribute.column_name %>].present?}" %> |
There was a problem hiding this comment.
Add the is-invalid class to the input, maybe this logic should be moved into a variable to avoid the repetition.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the controller and form template so that validation errors are rendered on the screen like this.
It works by including the https://github.com/jorgemanrubia/turbolinks_render gem, this gem makes it so that HTML returned from a POST request will be rendered by Turbolinks.
I have then updated the controller template to set the errors and I've updated the form template to display the errors inline.