Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated SMP protos #70

Merged
merged 11 commits into from
Jan 25, 2021
Merged

Integrated SMP protos #70

merged 11 commits into from
Jan 25, 2021

Conversation

dhruv0000
Copy link
Member

@dhruv0000 dhruv0000 commented Dec 16, 2020 •
edited
Loading

Signed-off-by: dhruv0000 [email protected]

Description
Conformance Proto Changes:

  • Capability TestStatus and ResultStatus are now represented as enum
  • Request now only takes ServiceMesh type as Request (Thanks to PR #158 in SMP repo)

Changes in SMI tool:

  • Now uses ServiceMesh_Type enum from SMP repo to identify mesh instead of a string

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@dhruv0000
Integrated SMP protos
6cb70e0 
Signed-off-by: dhruv0000 <[email protected]>
@dhruv0000 dhruv0000 marked this pull request as ready for review December 23, 2020 14:05
@leecalcote
Copy link
Member

Can you speak briefly to this on today's Meshery Dev call?

@leecalcote leecalcote added the pr/draft WIP/Draft pull request label Jan 20, 2021
@leecalcote
Copy link
Member

Thanks for being on the call today, @dhruv0000. I have added the PR/Draft label here assuming it's still in draft mode.

@dhruv0000 dhruv0000 marked this pull request as draft January 24, 2021 20:52
@dhruv0000 dhruv0000 mentioned this pull request Jan 25, 2021
Merged
1 task
@dhruv0000 dhruv0000 marked this pull request as ready for review January 25, 2021 01:32
leecalcote
leecalcote approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leecalcote leecalcote merged commit 43e1dc9 into layer5io:master Jan 25, 2021
@dhruv0000 dhruv0000 mentioned this pull request Jan 27, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote approved these changes

@kumarabd kumarabd Awaiting requested review from kumarabd

Assignees
No one assigned
Labels
pr/draft WIP/Draft pull request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruv0000 @leecalcote