Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Invalid read more button removed. #5817

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SyedAyaanAli6786
Copy link

@SyedAyaanAli6786 SyedAyaanAli6786 commented Aug 14, 2024

Description

This PR fixes #5814 using conditional rendering .

Notes for Reviewers

Signed commits

  • [x ] Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Aug 14, 2024

🚀 Preview for commit 5f8ee23 at: https://66bd0f714adcc41c087bdfef--layer5.netlify.app

Copy link
Contributor

@Ashparshp Ashparshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SyedAyaanAli6786, please fix the DCO sign-off. If you're unaware, read more about it in the contributing guide.

@l5io
Copy link
Contributor

l5io commented Aug 16, 2024

🚀 Preview for commit 35fc558 at: https://66bf2bcbc24898ffdb946be1--layer5.netlify.app

@Ashparshp
Copy link
Contributor

@SyedAyaanAli6786, Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@Ashparshp
Copy link
Contributor

@SyedAyaanAli6786, please join. The meeting has started.

@SyedAyaanAli6786
Copy link
Author

SyedAyaanAli6786 commented Aug 19, 2024

@Ashparshp Hello, I didn't saw this message of yours. I was a little busy today. I will surely join the next meeting.

@Ashparshp
Copy link
Contributor

Thank you @SyedAyaanAli6786 for sending words, are you on slack?

@SyedAyaanAli6786
Copy link
Author

No @Ashparshp currently I'm not on slack, but I can join if you say.

@Ashparshp
Copy link
Contributor

@SyedAyaanAli6786, yes please!

@Ashparshp
Copy link
Contributor

@SyedAyaanAli6786, Joined? and also, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@SyedAyaanAli6786
Copy link
Author

Yes @Ashparshp joined slack.

Copy link
Member

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SyedAyaanAli6786 can you plesae increase the font-size for Read More ? It's barely visible.
image

@Ashparshp
Copy link
Contributor

@vishalvivekm, the ask was to remove the read more as it was invalid here. Please recheck the issue again.

@Ashparshp
Copy link
Contributor

@SyedAyaanAli6786, Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT). Please consider adding it as an agenda item to the meeting minutes || meeting link.

@Ashparshp
Copy link
Contributor

I'm adding this as an agenda item to the meeting minutes. Please join the evening call.

@SyedAyaanAli6786
Copy link
Author

Ok @Ashparshp, thanks for the invitation. I will be there at the meeting. Can you tell me what will be my role in the meeting (what will I tell) ?

@Ashparshp
Copy link
Contributor

In the meeting, we discussed the PRs and updates on the work and provide feedback. This is the fastest way to move forward with the PRs.

Copy link
Contributor

@Ashparshp Ashparshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since both components use the same pattern for rendering links, create a shared component to eliminate duplication and ensure consistency.

make sense?

@Ashparshp
Copy link
Contributor

@SyedAyaanAli6786, any luck?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[UI] Found Invalid read more button
4 participants