-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Added Components dropdown functionality, resolved small devices dropdown issues #5722
base: master
Are you sure you want to change the base?
Conversation
…own issues Signed-off-by: Muhammad Moinuddin <[email protected]>
🚀 Preview for commit c0059d0 at: https://66a0d372d54a9cf62f93852f--layer5.netlify.app |
}`} | ||
activeClassName="active" | ||
> | ||
Button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why they are static? Shouldn't they be dynamic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just followed the previous way of code (i.e. static). Dynamic would be great. I'll look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, please propose a change if you would
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will.
@Muhammed-Moinuddin Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
Not fruitful. I need to make changes in it. |
🚀 Preview for commit be5170d at: https://66b8ccf5a3dcf17322b4843e--layer5.netlify.app |
🚀 Preview for commit f2cbf60 at: https://66b915c1e24d819efd07976a--layer5.netlify.app |
Signed-off-by: Muhammad Moinuddin <[email protected]>
🚀 Preview for commit 56ac93d at: https://66b924e1fdff58b4813d4342--layer5.netlify.app |
@Muhammed-Moinuddin, Thank you! Let's discuss this during the website call and get it merged. Please consider adding it as an agenda item to the meeting minutes || meeting link. |
@Muhammed-Moinuddin please resolve the merge conflicts. so we can move ahead. |
Description
Made Table of Content (button) and dropdown workable on small devices.
Added dropdown functionality to components.
This PR fixes #5694 #5677
Notes for Reviewers
Signed commits