Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Who Can Use This Feature in meshmap and cloud #348

Closed
wants to merge 0 commits into from

Conversation

SAHU-01
Copy link
Contributor

@SAHU-01 SAHU-01 commented Aug 12, 2024

Notes for Reviewers

This PR fixes #89

  1. Adds a YML datafile comprising information about the features available under each subscription plan
  2. Adds front-matter on top of each feature page in documentation
image

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit de83668
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/66fa0dbc79f4020008585146
😎 Deploy Preview https://deploy-preview-348--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ashparshp
Copy link
Contributor

@SAHU-01, Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@leecalcote
Copy link
Member

@sudhanshutech @Yashsharma1911 @vishalvivekm please confirm that this data will be centrally tracked in spreadsheet and programmatically published / refreshed.

font-weight: bold;
margin-left:10px
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this subscription function might benefit from a new _styles_<something>.scss in the hopes of keeping CSS files shorter, than longer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll do that!

Copy link
Contributor

@marblom007 marblom007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this is a nice feature of the docs to have, so that it's readily evident what features and functions are available in which subscription plan.

I wonder, though, am I seeing right list item icon? This is a Discourse icon. Is there a special reason for this? What does it mean?

Screenshot 2024-08-20 at 5 02 46 PM

@SAHU-01
Copy link
Contributor Author

SAHU-01 commented Aug 21, 2024

In general, this is a nice feature of the docs to have, so that it's readily evident what features and functions are available in which subscription plan.

I wonder, though, am I seeing right list item icon? This is a Discourse icon. Is there a special reason for this? What does it mean?

Screenshot 2024-08-20 at 5 02 46 PM

Yes, regarding that icon, that is the disclosure icon, the most suitable icon i could find, I just added that and waited for a feedback, I'll be changing it, I've received an icon svg that matches the subscription usecase.
Thanks for pointing that out though!

@Ashparshp
Copy link
Contributor

@SAHU-01, Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Create a "Who Can Use This Feature" layout/block/shortcode
4 participants