Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PRT Block Hash Retry Archive After Redesign Part 2 - Add Archive logic to CRSM #1727

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

ranlavanet
Copy link
Collaborator

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@ranlavanet ranlavanet changed the title feat: PRT - block hash cache after redesign part 2 feat: PRT Block Hash Retry Archive After Redesign Part 2 Oct 3, 2024
@ranlavanet ranlavanet self-assigned this Oct 3, 2024
@ranlavanet ranlavanet changed the title feat: PRT Block Hash Retry Archive After Redesign Part 2 feat: PRT Block Hash Retry Archive After Redesign Part 2 - Add Archive logic to crsm Oct 3, 2024
@ranlavanet ranlavanet changed the title feat: PRT Block Hash Retry Archive After Redesign Part 2 - Add Archive logic to crsm feat: PRT Block Hash Retry Archive After Redesign Part 2 - Add Archive logic to CRSM Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

Test Results

2 079 tests   - 152   2 077 ✅  - 154   25m 48s ⏱️ -56s
  143 suites  -   2       0 💤 ±  0 
    6 files    -   1       0 ❌ ±  0   2 🔥 +2 

For more details on these errors, see this check.

Results for commit 618fa81. ± Comparison against base commit 213d0c6.

This pull request removes 152 tests.
github.com/lavanet/lava/v4/ecosystem/cache ‑ TestCacheExpirationMultiplier
github.com/lavanet/lava/v4/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_1
github.com/lavanet/lava/v4/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_1.2
github.com/lavanet/lava/v4/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_2
github.com/lavanet/lava/v4/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_2.5
github.com/lavanet/lava/v4/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_200
github.com/lavanet/lava/v4/ecosystem/cache ‑ TestCacheFailSetWithInvalidRequestBlock
github.com/lavanet/lava/v4/ecosystem/cache ‑ TestCacheFailSetWithInvalidRequestBlock/Finalized_After_delay_No_Hash
github.com/lavanet/lava/v4/ecosystem/cache ‑ TestCacheFailSetWithInvalidRequestBlock/Finalized_After_delay_No_Hash#01
github.com/lavanet/lava/v4/ecosystem/cache ‑ TestCacheFailSetWithInvalidRequestBlock/Finalized_After_delay_With_Hash
…

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants