Fix some memory leaks #278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't intend to close this PR -- looks like something weird happened. |
|
If you're compiling with g++, compile with address sanitizer ( -fsanitize=address and link against libasan), e.g. for examples/surface.cpp g++ -g -Wall -fsanitize=address -o surface This will show you all memory leaks. Before your changes, and after. |
Gonzalo-Mier
added a commit
to Fields2Cover/matplotlib-cpp
that referenced
this pull request
Sep 10, 2022
PR obtain from lava#278
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a program I wrote, I had to plot a few hundreds of matplotlib plots, and memory usage went up to 5 Gb despite calling
plt::clf()andplt::close()after each plot. Removing all instances ofPy_INCREFseems to solve the issue, sincePy_INCREFis not needed on return values ofPyObject_GetAttrStringandPyObject_Call, according to https://docs.python.org/3/extending/extending.html#ownership-rules.