Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Resolves #8791: Revert to react-native-sidemenu-updated for navigation drawers #8820

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Sep 10, 2023

Summary

See #8792

@react-navigation/drawer causes application crashes in some cases.

Notes

This pull request causes the following regressions:

  • The side menu always appears to be open to accessibility tools, interfering with exploring the screen with touch and making it more difficult to navigate to items on the screen. issue
    • A possible fix for this would be to set accessibilityElementsHidden and importantForAccessibility="no-hide-descendants" (source) on the sidemenu content whenever the menu is hidden.
    • Edit: I have a fix for this locally. Should it be included in this pull request? If not, I think it may still make sense to include this in the patch release (as it prevents a regression).

It has been verified on Android and iOS that the main and note properties sidemenus still open and close with this pull request.

width: this.state.sideMenuWidth,
<SideMenu
menu={sideMenuContent}
edgeHitWidth={20}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edgeHitWidth was originally 5, however, on my devices, this doesn't seem large enough to allow opening the menu with touch. As such, it was increased to 20.

With react-native-sidemenu, an edgeHitWidth of 15 seems too small on my Android device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants