Merge branch 'unit_test_O2' into all_fixes

.github/workflows/Dockerfile.gnu

@@ -0,0 +1,68 @@
+#***********************************************************************
+#*                   GNU Lesser General Public License
+#*
+#* This file is part of the GFDL Flexible Modeling System (FMS).
+#*
+#* FMS is free software: you can redistribute it and/or modify it under
+#* the terms of the GNU Lesser General Public License as published by
+#* the Free Software Foundation, either version 3 of the License, or (at
+#* your option) any later version.
+#*
+#* FMS is distributed in the hope that it will be useful, but WITHOUT
+#* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+#* FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+#* for more details.
+#*
+#* You should have received a copy of the GNU Lesser General Public
+#* License along with FMS.  If not, see <http://www.gnu.org/licenses/>.
+#***********************************************************************
+# FMS CI image recipefile for GNU
+# Runs on centos stream (builder has same base from redhat registry)
+#
+# arguments to specify versions to build can be given to docker or changed here (--build-arg name=val)
+FROM spack/rockylinux9:latest as builder
+
+ARG gcc_version=12.3.0
+ARG netcdfc_version=4.9.0
+ARG netcdff_version=4.6.0
+ARG libyaml_version=0.2.5
+ARG mpich_version=4.0.2
+
+COPY spack.env /opt/deps/spack.env
+
+# perl's download kept timing out
+RUN sed -i 's/connect_timeout: 10/connect_timeout: 600/' /opt/spack/etc/spack/defaults/config.yaml && \
+    spack install gcc@${gcc_version}                          && \
+    source /opt/spack/share/spack/setup-env.sh                && \
+    spack load gcc@${gcc_version}                             && \
+    spack compiler find                                       && \
+    sed "s/COMPILER/gcc@$gcc_version/" /opt/deps/spack.env > spack.yaml && \
+    sed -i "s/NETCDF_C_VERSION/$netcdfc_version/" spack.yaml  && \
+    sed -i "s/NETCDF_F_VERSION/$netcdff_version/" spack.yaml  && \
+    sed -i "s/LIBYAML_VERSION/$libyaml_version/" spack.yaml   && \
+    sed -i "s/MPI_LIB/mpich@$mpich_version/" spack.yaml       && \
+    spack env activate -d .                                   && \
+    spack -e . concretize -f > /opt/deps/deps.log             && \
+    spack install --fail-fast
+
+# copy built software to base from first image
+FROM rockylinux:9
+
+COPY --from=builder /opt/view/ /opt/view/
+COPY --from=builder /opt/deps/ /opt/deps/
+
+# input files used with --enable-input-tests
+# need to be on the dev boxes if building
+COPY ./fms_test_input /home/unit_tests_input
+
+RUN dnf install -y autoconf make automake m4 libtool pkg-config zip
+
+ENV FC="mpifort"
+ENV CC="mpicc"
+ENV MPICH_FC="/opt/view/bin/gfortran"
+ENV MPICH_CC="/opt/view/bin/gcc"
+ENV FCFLAGS="-I/opt/view/include"
+ENV CFLAGS="-I/opt/view/include"
+ENV LDFLAGS="-L/opt/view/lib"
+ENV LD_LIBRARY_PATH="/opt/view/lib:/opt/view/lib64:/usr/local/lib:/usr/local/lib64"
+ENV PATH="/opt/view/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin"

.github/workflows/github_autotools_gnu.yml

@@ -0,0 +1,39 @@
+# 'main' required ci, does a distcheck (builds, tests, check install)
+# image created off dockerfile in repo, compile/link flags are set there
+name: Build libFMS test with autotools
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        conf-flag: [ --disable-openmp, --enable-mixed-mode, --disable-setting-flags, --with-mpi=no]
+        input-flag: [--with-yaml, --enable-test-input=/home/unit_tests_input]
+        exclude:
+          - conf-flag: --with-mpi=no
+            input-flag: --enable-test-input=/home/unit_tests_input
+    container:
+      image: noaagfdl/fms-ci-rocky-gnu:12.3.0
+      env:
+        TEST_VERBOSE: 1
+        DISTCHECK_CONFIGURE_FLAGS: "${{ matrix.conf-flag }} ${{ matrix.input-flag }} ${{ matrix.io-flag }}"
+        SKIP_TESTS: "test_mpp_domains2.14 test_horiz_interp2.9 test_horiz_interp2.10 test_yaml_parser.5" # temporary till fixes are in
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v2
+    - name: Prepare GNU autoconf for build
+      run: autoreconf -if
+    - name: Configure the build
+      if: ${{ matrix.conf-flag != '--disable-setting-flags' }}
+      run: ./configure ${DISTCHECK_CONFIGURE_FLAGS} || cat config.log
+    - name: Configure the build with compiler flags
+      if: ${{ matrix.conf-flag == '--disable-setting-flags' }}
+      run: ./configure ${DISTCHECK_CONFIGURE_FLAGS} FCFLAGS="-fdefault-real-8 -fdefault-double-8 -fcray-pointer -ffree-line-length-none -I/usr/include $FCFLAGS" || cat config.log
+    - name: Build the library
+      run: make distcheck
+      if: ${{ matrix.conf-flag != '--with-mpi=no' }}
+    - name: Build the library (without test suite for serial build)
+      run: make
+      if: ${{ matrix.conf-flag == '--with-mpi=no' }}

.github/workflows/spack.env

@@ -0,0 +1,17 @@
+# template for spack environment yaml
+# uppercase words get replaced before activating
+spack:
+  specs:
+    - COMPILER
+    - MPI_LIB
+    - netcdf-c@NETCDF_C_VERSION ^MPI_LIB
+    - netcdf-fortran@NETCDF_F_VERSION
+    - libyaml@LIBYAML_VERSION
+  concretizer:
+    unify: true
+  packages:
+    all:
+      compiler: [ COMPILER ]
+  config:
+    install_tree: /opt/deps
+  view: /opt/view

.github/workflows/version.yml

@@ -1,3 +1,5 @@
+# appends -dev to the version upon release and opens pr
+# CI won't run on generated PR, easiest workaround is to close + reopen
 on:
   release:
     types: [published]
@@ -16,4 +18,4 @@ jobs:
         branch-suffix: timestamp     # add a timestamp to branch name
         delete-branch: true          # delete afer merge
         title: Append dev to version number post-release
-        body: automated change, adds '-dev' to the version number upon releases
+        body: automated change, adds '-dev' to the version number upon releases. This PR will need to be closed and reopened to run CI testing.

CHANGELOG.md

@@ -6,6 +6,45 @@ and this project uses `yyyy.rr[.pp]`, where `yyyy` is the year a patch is releas
 `rr` is a sequential release number (starting from `01`), and an optional two-digit
 sequential patch number (starting from `01`).
 
+## [2023.02] - 2023-07-27
+### Known Issues
+- GCC 11.1.0 is unsupported due to compilation issues with select type. The issue is resolved in later GCC releases.
+- When outputting sub-region diagnostics, the current diag_manager does not add "tileX" to the filename when using a cube sphere. This leads to trouble when trying to combine the files and regrid them (if the region is in two different tiles)
+- GCC 10 and greater causing io issues when compiled using O2 optimization flags
+- GNU compilers prior to the GCC 9.0 release are unsupported for this release due to lack of support for the findloc intrinsic function. This will result in an error saying 'findloc' has no IMPLICIT type and can be resolved by compiling with gcc version 9.0 or greater.
+
+### Added
+- MPP/EXCHANGE: Adds association checks before pointer deallocations in mpp includes and xgrid
+
+### Changed
+- LIBFMS: The libFMS.F90 file (module name `fms`) meant to provide global access has been updated to include 'fms' and it's module/subdirectory name as prefixes for all names. This will only affect external codes that are already using the global module (via `use fms`) and not individual modules.
+- MIXED PRECISION: Updates the axis_utils2, horiz_interp, sat_vapor_pressure, and axis_utils subdirectories to support mixed precision real values.
+- FMS2_IO: Added in mpp_scatter and mpp_gather performance changes from the 2023.01.01 patch. See below for more details.
+- FMS2_IO: Improved error messages to give more debugging information 
+- FMS_MOD: Changed fms_init to include a system call to set the stack size to unlimited, removed previously added stack size fixes
+- MONIN_OBUKHOV: Restructures the subroutines in `stable_mix` interface so that 1d calls the underlying implementation, and 2 and 3d call it on 1d slices of the data as opposed to passing in mismatched arrays.
+- MPP: Updates from JEDI for ajoint version the mpp halo filling (mpp_do_update_ad.fh), adds checkpoint for forward buffer information.
+
+### Fixed
+- MPP: mpp_broadcast causing an unintended error message due to checking the wrong pe value
+- MPP: Added workaround for GCC 12 issues causing errors with string lengths in fms2_io
+- FMS2_IO: Fixed support for 'packed' data when using NF_SHORT variables. Scale_factor and add_offset attributes will now be applied if present.
+- DOCS: Improved doxygen comments for tranlon, updated deployment action for site
+- TESTS: Workaround added for ICE coming from mpp_alltoall test with intel 2022.3, and fixes for any test scripts missing input.nml creation. Fixes for mpp/test_global_array failures.
+- TIME_INTERP: Fixes crashes when calling with a non-existant field
+- DIAG_MANAGER: Fixes a module dependency issue causing failures during parallel builds
+- AXIS_UTILS2: Fixes an out of bounds memory index
+
+### Removed
+- FMS_IO/MPP_IO: The two older io modules, fms_io_mod and mpp_io_mod, have been deprecated and will not be compiled by default. If you wish to compile these modules, you must use the -Duse_deprecated_io CPP flag or the --enable-deprecated-io configure option if building with autotools.
+
+### Tag Commit Hashes
+- 2023.02-beta1  2be8aa452ad3e5f43e92c38a64f12d1ae6c43fb8
+- 2023.02-alpha3 8c73bd18dc1d580f2ee524c37cf903ff54d40501
+- 2023.02-alpha2 783019fdec89a8db2b26247c2f63d4782e1495c0
+- 2023.02-alpga1 419c66be31f82ebb13a91ea5e837c707eb54473b
+
+
 ## [2023.01.01] - 2023-06-06
 ### Changed
 - FMS2_IO: Performance changes for domain_reads_2d and domain_reads_3d:

CI.md

@@ -8,24 +8,30 @@ Required CI for pull requests are listed first.
 ## Pull Request CI and checks
 
 ### Build libFMS with autotools
+
 Required GNU build test for all pull requests/pushes.
 Runs `make distcheck` after configuring via GNU autotools.
 
+Runs on a container image with spack installed dependencies, on top a rocky linux base.
+
+Dockerfile for image is stored at .github/workflows/Dockerfile.gnu for more specific information on the CI environment.
+
 Container environment:
-gcc            v7.3.0
-mpich          v3.3a2
-netcdf         v4.6.0
-netcdf-fortran v4.4.4
+gcc            v12.3.0
+mpich          v4.0.2
+netcdf         v4.9.0
+netcdf-fortran v4.6.0
 autoconf       v2.69
+libyaml        v0.2.5
 
-container hosted at [noaagfdl/ubuntu_libfms_gnu:latest](https://hub.docker.com/r/noaagfdl/ubuntu_libfms_gnu)
-
-`./configure` flags:
-- `--enable-openmp`
+`./configure` flags tested:
 - `--disable-openmp`
 - `--enable-mixed-mode`
+- `--with-mpi=no` (disables unit testing)
 - `--disable-setting-flags`
 - `--with-yaml`
+- `--enable-test-input=/home/unit_tests_input`
+
 
 ### Build libfms with cmake
 Required GNU build test for all pull requests/pushes.

CMakeLists.txt

@@ -26,7 +26,7 @@ set(CMAKE_Fortran_FLAGS_DEBUG)
 
 # Define the CMake project
 project(FMS
-  VERSION 2023.01.0
+  VERSION 2023.02.0
   DESCRIPTION  "GFDL FMS Library"
   HOMEPAGE_URL "https://www.gfdl.noaa.gov/fms"
   LANGUAGES C Fortran)
@@ -196,6 +196,7 @@ list(APPEND fms_fortran_src_files
 # Collect FMS C source files
 list(APPEND fms_c_src_files
   affinity/affinity.c
+  fms/fms_stacksize.c
   mosaic/create_xgrid.c
   mosaic/gradient_c2l.c
   mosaic/interp.c

configure.ac

@@ -25,7 +25,7 @@ AC_PREREQ([2.69])
 
 # Initialize with name, version, and support email address.
 AC_INIT([GFDL FMS Library],
-  [2023.01.00-dev],
+  [2023.02.00-dev],
   [[email protected]],
   [FMS],
   [https://www.github.com/NOAA-GFDL/FMS])

libFMS/Makefile.am

@@ -28,7 +28,7 @@ lib_LTLIBRARIES = libFMS.la
 # These linker flags specify libtool version info.
 # See http://www.gnu.org/software/libtool/manual/libtool.html#Libtool-versioning
 # for information regarding incrementing `-version-info`.
-libFMS_la_LDFLAGS = -version-info 15:0:0
+libFMS_la_LDFLAGS = -version-info 16:0:0
 
 # Add the convenience libraries to the FMS library.
 libFMS_la_LIBADD = $(top_builddir)/platform/libplatform.la

mpp/include/mpp_gather.fh

@@ -111,19 +111,22 @@ end subroutine MPP_GATHER_1DV_
 
 subroutine MPP_GATHER_PELIST_2D_(is, ie, js, je, pelist, array_seg, data, is_root_pe, &
                                  ishift, jshift)
-   integer,                           intent(in)    :: is, ie, js, je
-   integer,   dimension(:),           intent(in)    :: pelist
-   MPP_TYPE_, dimension(is:ie,js:je), intent(in)    :: array_seg
-   MPP_TYPE_, dimension(:,:),         intent(inout) :: data
-   logical,                           intent(in)    :: is_root_pe
-   integer,   optional,               intent(in)    :: ishift, jshift
-
-   MPP_TYPE_ ::  arr3D(size(array_seg,1),size(array_seg,2),1)
-   MPP_TYPE_ :: data3D(size(     data,1),size(     data,2),1)
-   pointer( aptr,  arr3D )
-   pointer( dptr, data3D )
-   aptr = LOC(array_seg)
-   dptr = LOC(     data)
+   integer,                                       intent(in)    :: is, ie, js, je
+   integer,   dimension(:),                       intent(in)    :: pelist
+   MPP_TYPE_, dimension(is:ie,js:je),     target, intent(in)    :: array_seg
+   MPP_TYPE_, dimension(:,:), contiguous, target, intent(inout) :: data
+   logical,                                       intent(in)    :: is_root_pe
+   integer,   optional,                           intent(in)    :: ishift, jshift
+
+   MPP_TYPE_, pointer ::  arr3D(:,:,:)
+   MPP_TYPE_, pointer :: data3D(:,:,:)
+
+   arr3D(1:size(array_seg,1),1:size(array_seg,2),1:1) => array_seg
+   if (is_root_pe) then
+     data3D(1:size(data,1),1:size(data,2),1:1) => data
+   else
+     data3D => null()
+   endif
 
    call mpp_gather(is, ie, js, je, 1, pelist, arr3D, data3D, is_root_pe, &
                    ishift, jshift)

mpp/include/mpp_scatter.fh

@@ -29,17 +29,20 @@ subroutine MPP_SCATTER_PELIST_2D_(is, ie, js, je, pelist, array_seg, data, is_ro
    integer,                           intent(in)    :: is, ie, js, je !< indices of segment array
    integer,   dimension(:),           intent(in)    :: pelist !<PE list of target pes,
                                                               !! must be in monotonic increasing order
-   MPP_TYPE_, dimension(is:ie,js:je), intent(inout)    :: array_seg !< 2D array of output data
-   MPP_TYPE_, dimension(:,:),         intent(in) :: data !< 2D array of input data
+   MPP_TYPE_, dimension(is:ie,js:je), target, intent(inout)  :: array_seg !< 2D array of output data
+   MPP_TYPE_, dimension(:,:), contiguous, target, intent(in) :: data !< 2D array of input data
    logical,                           intent(in)    :: is_root_pe !< true if calling from root
    integer,   optional,               intent(in)    :: ishift, jshift !< Offsets of array elements
 
-   MPP_TYPE_ ::  arr3D(size(array_seg,1),size(array_seg,2),1)
-   MPP_TYPE_ :: data3D(size(     data,1),size(     data,2),1)
-   pointer( aptr,  arr3D )
-   pointer( dptr, data3D )
-   aptr = LOC(array_seg)
-   dptr = LOC(     data)
+   MPP_TYPE_, pointer ::  arr3D(:,:,:)
+   MPP_TYPE_, pointer :: data3D(:,:,:)
+
+   arr3D(1:size(array_seg,1),1:size(array_seg,2),1:1) => array_seg
+   if (is_root_pe) then
+     data3D(1:size(data,1),1:size(data,2),1:1) => data
+   else
+     data3D => null()
+   endif
 
    call mpp_scatter(is, ie, js, je, 1, pelist, arr3D, data3D, is_root_pe, &
                     ishift, jshift)

test_fms/fms2_io/test_bc_restart.sh

@@ -43,7 +43,7 @@ test_expect_failure "bad checksum" '
 '
 
 # run test 3 - test for ignoring a bad checksum
-printf "&test_bc_restart_nml\n bad_checksum=.true.\n ignore_checksum=.true./" | cat > input.nml
+printf "&test_bc_restart_nml\n bad_checksum=.true.\n ignore_checksum=.true.\n /" | cat > input.nml
 test_expect_success "ignore bad checksum" '
   mpirun -n 16 ../test_bc_restart
 '

test_fms/fms2_io/test_domain_io.F90

@@ -46,7 +46,7 @@ program test_domain_read
   integer                               :: xhalo = 3           !< Number of halo points in X
   integer                               :: yhalo = 2           !< Number of halo points in Y
   integer                               :: nz = 2              !< Number of points in the z dimension
-  character(len=20)                     :: filename="test.nc"  !< Name of the file
+  character(len=32)                     :: filename="test.nc"  !< Name of the file
   logical                               :: use_edges=.false.   !< Use North and East domain positions
 
   integer                               :: ndim4               !< Number of points in dim4
@@ -64,7 +64,7 @@ program test_domain_read
 
   namelist /test_domain_io_nml/ layout, io_layout, nx, ny, nz, mask_table, xhalo, yhalo, nz, filename, use_edges
 
-  call fms_init
+  call fms_init()
 
   read(input_nml_file, nml=test_domain_io_nml, iostat=io)
   ierr = check_nml_error(io, 'test_domain_io_nml')
@@ -134,7 +134,7 @@ program test_domain_read
 
     call close_file(fileobj)
   endif
-  call fms_end
+  call fms_end()
 
   contains