feat: Add URLs for custom events and URL filtering. #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Sep 19, 2024
| @@ -1,4 +1,4 @@ | |||
| export const LOCATION_WATCHER_INTERVAL = 300; | |||
There was a problem hiding this comment.
Meant to address this in the other PR, but catching it here.
kinyoklion
commented
Sep 19, 2024
| return new BrowserClient(clientSideId, autoEnvAttributes, options); | ||
| export function init(clientSideId: string, options?: LDOptions): LDClient { | ||
| // AutoEnvAttributes are not supported yet in the browser SDK. | ||
| return new BrowserClient(clientSideId, AutoEnvAttributes.Disabled, options); |
There was a problem hiding this comment.
When we add browser auto attributes we add this.
kinyoklion
commented
Sep 19, 2024
| @@ -10,8 +8,8 @@ export default class BrowserInfo implements Info { | |||
| } | |||
| sdkData(): SdkData { | |||
| return { | |||
| name, | |||
| version, | |||
| name: '@launchdarkly/js-client-sdk', | |||
There was a problem hiding this comment.
This is to make builds simpler.
kinyoklion
commented
Sep 19, 2024
| @@ -22,9 +22,9 @@ export default class BrowserPlatform implements Platform { | |||
| requests: Requests = new BrowserRequests(); | |||
| storage?: Storage; | |||
|
|
|||
| constructor(options: LDOptions) { | |||
| constructor(logger: LDLogger) { | |||
There was a problem hiding this comment.
Decrease scope of dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.