fix(common): fix elementary type state mutability handling #3682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another old bug that never came up apparently
I only fix this for worldgen, system libraries still don't support this, see the TODO
(similar to #3660)
For system libs this can probably be solved by hacking
renderAbiDecode
to check for/payable(\[.*\])?/
A better solution would require refactoring
contractToInterface
to return more nuanced parameter data (types,names separately)Anyways
address payable[]
isn't important to support, this change is more about removing incorrect assumptions fromcontractToInterface
, and simplifyingflattenTypeName