Skip to content

fix(common): fix elementary type state mutability handling #3682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dk1a
Copy link
Contributor

@dk1a dk1a commented Apr 18, 2025

This is another old bug that never came up apparently
I only fix this for worldgen, system libraries still don't support this, see the TODO
(similar to #3660)

For system libs this can probably be solved by hacking renderAbiDecode to check for /payable(\[.*\])?/
A better solution would require refactoring contractToInterface to return more nuanced parameter data (types,names separately)

Anyways address payable[] isn't important to support, this change is more about removing incorrect assumptions from contractToInterface, and simplifying flattenTypeName

Copy link

changeset-bot bot commented Apr 18, 2025

⚠️ No Changeset found

Latest commit: 5994048

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dk1a dk1a marked this pull request as ready for review April 18, 2025 12:14
@dk1a dk1a requested a review from alvrs as a code owner April 18, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant