-
Notifications
You must be signed in to change notification settings - Fork 211
feat(store): improve memory copy #3400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 34ca028 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
What do you do with store logs? The remaining failing tests seem unrelated and happen for me even on main |
@dk1a nice! I think you just need to update the vitest snapshots, go to the store package and run |
4a4c005
to
6f7d9b0
Compare
Reinstalling everything locally seems to have helped with docs - I'd run them before but had different results |
I'm curious why we see gas improvements in store but not world? |
|
combining all changes that require an audit into #3630 |
Memory.copy
behavior is unchanged (I changed dev comment however to better reflectmcopy
's description, rather than the previous workaround)Only the relevant bytecode is changing (which I think what
getStoreLogs.test.ts
is about)I wanted to use
mcopy
from the beginning, but back in 2023 that eip wasn't implemented yet, so the lengthy code was a less efficient workaroundWith solidity 0.8.24 the opcode is usable