clean up some casting in tests #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddyscientist
approved these changes
Nov 22, 2024
weinbe2
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
All looks good to me!
fyi @jcosborn if you hadn't already seen it, I'm working on a zoo of cleanups in the tests in the feature/host-gauge-creation-cleanup branch that I think jive well with what you're focusing on here. If you have the chance, please give a look at what I've done so far and let me know if you have any feedback on the changes I've been making.
Anyway---to my initial comment, this looks good, approv'd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.